Skip to content

Conversation

Sakuralbj
Copy link
Contributor

Ⅰ. Describe what this PR did

Add test information in cli_version_test.go.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #2891 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2891     +/-   ##
=========================================
- Coverage   68.91%   68.81%   -0.1%     
=========================================
  Files         291      291             
  Lines       18230    18249     +19     
=========================================
- Hits        12563    12558      -5     
- Misses       4215     4234     +19     
- Partials     1452     1457      +5
Flag Coverage Δ
#criv1alpha2_test 38.34% <ø> (-0.06%) ⬇️
#integration_test_0 36.12% <ø> (-0.03%) ⬇️
#integration_test_1 35.69% <ø> (-0.01%) ⬇️
#integration_test_2 36.01% <ø> (-0.01%) ⬇️
#integration_test_3 35.63% <ø> (-0.05%) ⬇️
#node_e2e_test 34.15% <ø> (-0.07%) ⬇️
#unittest 28.03% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
pkg/streams/utils.go 82.14% <0%> (-7.15%) ⬇️
cri/ocicni/netns.go 58.1% <0%> (-2.71%) ⬇️
daemon/mgr/container_copy.go 58.08% <0%> (-1.92%) ⬇️
cri/ocicni/cni_manager.go 59.25% <0%> (-1.86%) ⬇️
cri/v1alpha2/cri.go 68.81% <0%> (-0.51%) ⬇️
daemon/mgr/container_storage.go 60.03% <0%> (-0.43%) ⬇️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2019

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to pouch, @Sakuralbj
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

Signed-off-by: 630445639 <630445639@qq.com>
@pouchrobot pouchrobot added size/XS and removed size/S labels Jun 4, 2019
@pouchrobot
Copy link
Collaborator

@Sakuralbj Thanks for your contribution. 🍻
Please sign off in each of your commits.

@allencloud
Copy link
Collaborator

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jun 9, 2019
@allencloud allencloud merged commit 77659ab into AliyunContainerService:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants