Skip to content

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented May 10, 2019

Signed-off-by: Wei Fu fuweid89@gmail.com

Ⅰ. Describe what this PR did

support push command cli

Ⅱ. Does this pull request fix one issue?

fixes #2099

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #2832 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
+ Coverage   69.07%   69.13%   +0.05%     
==========================================
  Files         285      285              
  Lines       17758    17765       +7     
==========================================
+ Hits        12266    12281      +15     
+ Misses       4092     4086       -6     
+ Partials     1400     1398       -2
Flag Coverage Δ
#criv1alpha2_test 39% <0%> (+0.02%) ⬆️
#integration_test_0 36.63% <0%> (-0.03%) ⬇️
#integration_test_1 35.38% <0%> (+0.03%) ⬆️
#integration_test_2 36.51% <0%> (+0.01%) ⬆️
#integration_test_3 35.4% <0%> (-0.02%) ⬇️
#node_e2e_test 34.79% <0%> (+0.03%) ⬆️
#unittest 28.6% <0%> (-0.02%) ⬇️
Impacted Files Coverage Δ
ctrd/image.go 68.14% <0%> (-1.82%) ⬇️
ctrd/container.go 53.88% <0%> (-0.76%) ⬇️
cri/v1alpha2/cri.go 69.06% <0%> (ø) ⬆️
daemon/mgr/container.go 60.18% <0%> (+0.63%) ⬆️
daemon/logger/jsonfile/utils.go 73.17% <0%> (+1.62%) ⬆️
cri/ocicni/cni_manager.go 60.37% <0%> (+1.88%) ⬆️
cri/ocicni/netns.go 60.81% <0%> (+2.7%) ⬆️
pkg/streams/utils.go 91.66% <0%> (+9.52%) ⬆️

@rudyfly
Copy link
Collaborator

rudyfly commented May 10, 2019

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 10, 2019
@rudyfly rudyfly merged commit 0ab3003 into AliyunContainerService:master May 10, 2019
@fuweid fuweid deleted the me-push-cli branch May 10, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] build pouch push functionality (only cli side not finished now)
3 participants