Skip to content

Conversation

zhuangqh
Copy link
Contributor

@zhuangqh zhuangqh commented Apr 4, 2019

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

ensure there is a non-empty runtime name in sandbox metadata
the criplugin's action depends on runtime name

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

the criplugin's action depends on runtime name

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #2792 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
+ Coverage   69.26%   69.42%   +0.15%     
==========================================
  Files         277      277              
  Lines       17313    17313              
==========================================
+ Hits        11992    12019      +27     
+ Misses       3977     3956      -21     
+ Partials     1344     1338       -6
Flag Coverage Δ
#criv1alpha2_test 39.42% <100%> (+0.05%) ⬆️
#integration_test_0 36.55% <0%> (+0.01%) ⬆️
#integration_test_1 35.39% <0%> (+0.06%) ⬆️
#integration_test_2 36.36% <0%> (-0.09%) ⬇️
#integration_test_3 35.44% <0%> (+0.05%) ⬆️
#node_e2e_test 35.08% <100%> (+0.06%) ⬆️
#unittest 28.67% <0%> (ø) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri_utils.go 88.52% <100%> (+0.39%) ⬆️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
daemon/mgr/container.go 59.95% <0%> (-0.22%) ⬇️
ctrd/container.go 54.3% <0%> (+0.38%) ⬆️
daemon/mgr/container_utils.go 82.38% <0%> (+0.56%) ⬆️
cri/v1alpha2/cri.go 71.22% <0%> (+0.63%) ⬆️
cri/stream/runtime.go 70.23% <0%> (+2.38%) ⬆️
ctrd/watch.go 77.46% <0%> (+2.81%) ⬆️
apis/server/utils.go 75% <0%> (+3.84%) ⬆️
... and 2 more

@pouchrobot pouchrobot added kind/bug This is bug report for project size/XS labels Apr 4, 2019
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 06737bb into AliyunContainerService:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants