feat: When kube-eventer write data into InfluxDB will become more detial #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeusro
reviewed
Apr 10, 2020
sinks/influxdb/influxdb.go
Outdated
| const ( | ||
| eventMeasurementName = "log/events" | ||
| // Event special tags | ||
| eventUID = "uid" | ||
| // Value Field name | ||
| valueField = "value" | ||
|
|
||
| /* ---------------------------------*/ |
sinks/influxdb/influxdb.go
Outdated
| // getWorkloadName get workload name, deployment is no problem | ||
| func getWorkloadName(podName string) string{ | ||
| s := strings.Split(podName,"-") | ||
| n := len(s) - 2 |
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 52.12% 53.69% +1.56%
==========================================
Files 24 24
Lines 1483 1516 +33
==========================================
+ Hits 773 814 +41
+ Misses 645 634 -11
- Partials 65 68 +3
Continue to review full report at Codecov.
|
ringtail
reviewed
Apr 21, 2020
| @@ -28,6 +28,7 @@ import ( | |||
| influxdb "github.com/influxdata/influxdb/client" | |||
| kube_api "k8s.io/api/core/v1" | |||
| "k8s.io/klog" | |||
| jsoniter "github.com/json-iterator/go" | |||
There was a problem hiding this comment.
Could you remove external libs. json.Unmarshal should be enough
There was a problem hiding this comment.
I know. But the jsoniter handle JSON become so convenient , and the jsoniter is very quickly.
You can see the web pages:
https://github.com/json-iterator/go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kube-eventer write data into InfluxDB will become more detial