Skip to content

Conversation

@mpodolsk
Copy link
Contributor

@mpodolsk mpodolsk commented Jun 8, 2021

please approve so it stops crashing, thank you !
happy to address any questions / add more tests.

the optional issues should be addressed as well but that is for another pull request

@coveralls
Copy link

coveralls commented Jun 8, 2021

Coverage Status

Coverage increased (+0.003%) to 97.062% when pulling bcc1288 on mpodolsk:master into 95042c6 on Alir3z4:master.

@mpodolsk
Copy link
Contributor Author

mpodolsk commented Jun 9, 2021

hey @Alir3z4 let me know if I need to change anything / add something.

@Alir3z4
Copy link
Owner

Alir3z4 commented Jun 12, 2021

It's all good.
Thanks for taking care of it.

@Alir3z4 Alir3z4 merged commit e3ea63c into Alir3z4:master Jun 12, 2021
@Alir3z4
Copy link
Owner

Alir3z4 commented Jun 12, 2021

Fixes #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants