Insert whitespace at most once with multpile emphasis

AUTHORS.rst

@@ -31,6 +31,7 @@ The AUTHORS/Contributors are (and/or have been):
 * Jacek Kołodziej <kolodziejj@gmail.com>
 * Jonathan Vanasco <jonathan@findmeon.com>
 * Jon Dufresne <jon.dufresne@gmail.com>
+* Edward Ross <edward@skeptric.com>
 * Mike Borsetti
 
 Maintainer:

ChangeLog.rst

@@ -2,6 +2,7 @@ UNRELEASED
 ==========
 ----
 
+* Fix #332: Insert at most one space for multiple emphasis
 * Feature #318: Make padded tables more similar to pandoc's pipe_tables.
 * Add support for Python 3.9.
 * Fix extra line breaks inside html link text (between '[' and ']')

html2text/__init__.py

@@ -412,6 +412,7 @@ def no_preceding_space(self: HTML2Text) -> bool:
         if tag in ["em", "i", "u"] and not self.ignore_emphasis:
             if start and no_preceding_space(self):
                 emphasis = " " + self.emphasis_mark
+                self.preceding_data += " "
             else:
                 emphasis = self.emphasis_mark
 
@@ -422,6 +423,7 @@ def no_preceding_space(self: HTML2Text) -> bool:
         if tag in ["strong", "b"] and not self.ignore_emphasis:
             if start and no_preceding_space(self):
                 strong = " " + self.strong_mark
+                self.preceding_data += " "
             else:
                 strong = self.strong_mark
 
@@ -432,6 +434,7 @@ def no_preceding_space(self: HTML2Text) -> bool:
         if tag in ["del", "strike", "s"]:
             if start and no_preceding_space(self):
                 strike = " ~~"
+                self.preceding_data += " "
             else:
                 strike = "~~"
 

test/emphasis_whitespace.html

@@ -0,0 +1,31 @@
+<p> <em><strong>ib</strong></em></p>
+
+<p>.<em><strong>ib</strong></em></p>
+
+<p> <strong><em>bi</em></strong></p>
+
+<p>.<strong><em>bi</em></strong></p>
+
+<p> <em><strike>is</strike></em></p>
+
+<p>.<em><strike>is</strike></em></p>
+
+<p> <em><strike>si</strike></em></p>
+
+<p>.<em><strike>si</strike></em></p>
+
+<p> <strong><strike>bs</strike></strong></p>
+
+<p>.<strong><strike>bs</strike></strong></p>
+
+<p> <strike><strong>sb</strong></strike></p>
+
+<p>.<strike><strong>sb</strong></strike></p>
+
+<p> <strike><strong><em>sbi</em></strong></strike></p>
+
+<p>.<strike><strong><em>sbi</em></strong></strike></p>
+
+<p> <strong><em><strike>bis</strike></em></strong></p>
+
+<p>.<strong><em><strike>bis</strike></em></strong></p>

test/emphasis_whitespace.md

@@ -0,0 +1,32 @@
+_**ib**_
+
+. _**ib**_
+
+**_bi_**
+
+. **_bi_**
+
+_~~is~~_
+
+. _~~is~~_
+
+_~~si~~_
+
+. _~~si~~_
+
+**~~bs~~**
+
+. **~~bs~~**
+
+~~**sb**~~
+
+. ~~**sb**~~
+
+~~**_sbi_**~~
+
+. ~~**_sbi_**~~
+
+**_~~bis~~_**
+
+. **_~~bis~~_**
+

tox.ini

@@ -33,7 +33,7 @@ skip_install = true
 [testenv:isort]
 basepython = python3
 commands =
-    isort --check --diff .
+    isort --check-only --diff .
 deps =
     isort >= 5.0.1
 skip_install = true