[QC-1020] Custom Parameters for Post-Processing #2041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Communist Party for Perpetual Prosperity? |
Collaborator
Author
|
:-D Custom Parameters for Post-Processing |
Barthelemy
changed the title
Barthelemy
changed the title
knopers8
reviewed
Dec 7, 2023
Collaborator
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
Thanks, it seems OK, please address my few suggestions though.
| CustomParameters::CustomParameters() | ||
| { | ||
| mCustomParameters["default"]["default"] = {}; | ||
| mCustomParameters["null"]["null"] = {}; |
Collaborator
Author
There was a problem hiding this comment.
because we need to differentiate between the case when we have the defaults coming from a config file and this case
Comment on lines
54
to
64
| auto ppTree = config.get_child("qc.postprocessing." + id); | ||
| if (ppTree.count("extendedTaskParameters")) { | ||
| for (const auto& [runtype, subTreeRunType] : ppTree.get_child("extendedTaskParameters")) { | ||
| for (const auto& [beamtype, subTreeBeamType] : subTreeRunType) { | ||
| for (const auto& [key, value] : subTreeBeamType) { | ||
| customParameters.set(key, value.get_value<std::string>(), runtype, beamtype); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I am wondering if it's a good idea that code outside of CustomParameters is aware of the tree structure which is expected there. It might make any changes more prone to generating new bugs.
Collaborator
Author
There was a problem hiding this comment.
indeed, I have extracted it and put it in CustomParameters
Co-authored-by: Piotr Konopka <piotr.jan.konopka@cern.ch>
knopers8
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.