[PWGCF] Update lambdaR2Correlation.cxx #9656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yashpatley
commented
Jan 31, 2025
yashpatley
commented
- Updated pair efficiency histograms
- Added a process function for computation of correlation function from mix event method
1. Updated pair efficiency histograms 2. Added a process function for computation of correlation function from mix event method
yashpatley
requested review from
alibuild,
ariedel-cern,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
Comment on lines
+1317
to
+1321
| if (std::string(obj->ClassName()) == "TH2F") { | ||
| retVal = hist->GetBinContent(hist->FindBin(p1.pt(), p2.pt())); | ||
| } else if (std::string(obj->ClassName()) == "TH3F") { | ||
| retVal = hist->GetBinContent(hist->FindBin(p1.pt(), p2.pt(), dRap)); | ||
| } else { |
Collaborator
There was a problem hiding this comment.
I think I already suggested at some point to use the histogram number of dimensions instead of comparing strings at the pair loop level
Contributor
Author
There was a problem hiding this comment.
Dear Victor, It completely slipped my mind, I will do it in next PR. Thank you for reminding.
victor-gonzalez
approved these changes
Jan 31, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Have in mind that only the collisions in the same data frame are going to be mixed by the mixed event framework. If you really need mixed event probably you would need to consider derived data
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.