-
Notifications
You must be signed in to change notification settings - Fork 628
[PWGCF,PWGLF] Data model update #9510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
njacazio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Gleb
|
Just fix the mega linter |
|
Hi @victor-gonzalez could you please have a look? |
victor-gonzalez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine from my side
Please, for the next iterations start implementing linter recommendations
|
Tip top! Thanks! |
|
This is actually breaking the CI because it now creates an empty workflow if the tables are not present (like when we create the json in the builds). I can remove the protection, however that will result in an empty json. @jgrosseo will that create issues to HyperLoop? |
|
Hi @ktf this is a sort of pilot and uses the same procedure that we wanted to have in the unified converter and could be relevant also there. |
|
I will remove the check for now. In any case it should not be an assert, since whether or not the workflow is empty is not an internal detail and at the moment the check is only enforced in debug builds. Still we should understand what are the effects, since it means that effectively in the builds we will generate an empty workflow. |
|
@ktf An empty workflow means an empty json? |
@njacazio
@ercolessi