Skip to content

Conversation

@glromane
Copy link
Collaborator

@github-actions github-actions bot changed the title Data model update [PWGCF,PWGLF] Data model update Jan 24, 2025
njacazio
njacazio previously approved these changes Jan 24, 2025
Copy link
Collaborator

@njacazio njacazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gleb

@njacazio
Copy link
Collaborator

Just fix the mega linter

@njacazio
Copy link
Collaborator

Hi @victor-gonzalez could you please have a look?

Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from my side
Please, for the next iterations start implementing linter recommendations

@njacazio njacazio merged commit 163a1f7 into AliceO2Group:master Jan 27, 2025
13 of 14 checks passed
@njacazio
Copy link
Collaborator

Tip top! Thanks!

@ktf
Copy link
Member

ktf commented Jan 28, 2025

This is actually breaking the CI because it now creates an empty workflow if the tables are not present (like when we create the json in the builds). I can remove the protection, however that will result in an empty json. @jgrosseo will that create issues to HyperLoop?

@njacazio
Copy link
Collaborator

Hi @ktf this is a sort of pilot and uses the same procedure that we wanted to have in the unified converter and could be relevant also there.

@ktf
Copy link
Member

ktf commented Jan 28, 2025

I will remove the check for now. In any case it should not be an assert, since whether or not the workflow is empty is not an internal detail and at the moment the check is only enforced in debug builds. Still we should understand what are the effects, since it means that effectively in the builds we will generate an empty workflow.

@jgrosseo
Copy link
Contributor

@ktf An empty workflow means an empty json?
In this case, Hyperloop will not show any configurables...

smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants