[PWGCF] Flow for Phi meson using generic framework#9406
[PWGCF] Flow for Phi meson using generic framework#9406ktf merged 14 commits intoAliceO2Group:masterfrom
Conversation
… the new file name
github-actions
bot
changed the title
[PWGCF] Please consider the following formatting changes to AliceO2Group#9406
[PWGCF] Please consider the following formatting changes to AliceO2Group#9406
Preet-Bhanjan
requested review from
alibuild,
ariedel-cern,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
The O2linter errors in the CMakeLists are from other contributors |
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please consider my comment regarding naming the executable task and affected instances
PWGCF/Flow/Tasks/CMakeLists.txt
Outdated
| PUBLIC_LINK_LIBRARIES O2::Framework O2Physics::AnalysisCore O2Physics::GFWCore | ||
| COMPONENT_NAME Analysis) | ||
|
|
||
| o2physics_add_dpl_workflow(flow-pbpb-reso |
There was a problem hiding this comment.
There is nothing in the analysis really linked to PbPb so please, remove PbPb from the task executable name and preferably use resonances-gfw-flow if you are going to rely on GFW or resonances-flow if not, as task name. Modify accordingly the source file name and the task struct name
No problem with that |
|
I have implemented the suggested changes |
| if (!selectionTrack(track2)) { | ||
| continue; | ||
| } | ||
| // PID check | ||
| if (ispTdepPID && !selectionPIDpTdependent(track2)) { | ||
| continue; | ||
| } | ||
| if (!ispTdepPID && !selectionPID(track2)) { | ||
| continue; | ||
| } | ||
| auto track2ID = track2.globalIndex(); | ||
| if (track2ID == track1ID) { | ||
| continue; | ||
| } | ||
| if (!selectionPair(track1, track2)) { | ||
| continue; | ||
| } | ||
| if (removefaketrack && isFakeKaon(track1)) { | ||
| continue; | ||
| } | ||
| if (removefaketrack && isFakeKaon(track2)) { | ||
| continue; | ||
| } | ||
| histos.fill(HIST("KaminusTPC"), track2.pt(), track2.tpcNSigmaKa()); | ||
| histos.fill(HIST("KaminusTOF"), track2.pt(), track2.tofNSigmaKa()); | ||
| kaonPlus = ROOT::Math::PxPyPzMVector(track1.px(), track1.py(), track1.pz(), massKaPlus); | ||
| kaonminus = ROOT::Math::PxPyPzMVector(track2.px(), track2.py(), track2.pz(), massKaPlus); | ||
| phiMom = kaonPlus + kaonminus; | ||
| if (std::abs(phiMom.Rapidity()) < confRapidity) { | ||
| histos.fill(HIST("hPhiMass_sparse"), phiMom.M(), phiMom.Pt(), cent); | ||
| histos.fill(HIST("hPhi"), phiMom.Phi()); | ||
| histos.fill(HIST("hEta"), phiMom.Eta()); | ||
| } |
There was a problem hiding this comment.
Consider that this processing for track2 is repeated again for each track1
This has an evident effect on the singles histograms content, but also in the execution efficiency
- each track is selected
ntimes - each track is identified
ntimes - each track is checked as fake kaon
2ntimes
with n the number of K plus?
Have it in mind if you have execution warnings in hyperloop
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
I approve it for the time being but have a look at my comment regarding execution efficiency and unexpected effects in singles distributions
|
Please fix the linter in a subsequent PR. |
Co-authored-by: Preet Pati <preet@preet-2.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
4 participants
No description provided.