[PWGLF] Add centrality info, fix minor issues #9025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit of KF Hypernuclei task
Please consider the following formatting changes to AliceO2Group#8612
mhartung71
requested review from
alibuild,
njacazio and
skundu692
as code owners
mhartung71
requested review from
chiarapinto,
fmazzasc and
maciacco
as code owners
github-actions
bot
changed the title
njacazio
previously approved these changes
Dec 17, 2024
Collaborator
|
Hi @mhartung71 please fix the conflicts |
Contributor
Author
|
Hi @njacazio, the confilcts are now resolved |
njacazio
approved these changes
Dec 17, 2024
vkucera
reviewed
Dec 18, 2024
Collaborator
vkucera
left a comment
vkucera
left a comment
There was a problem hiding this comment.
@mhartung71 Thanks a lot for addressing the O2 linter warnings. Please see my comments below.
Comment on lines
-406
to
+399
| struct hypKfRecoTask { | ||
| struct hypKfRecoTask { // o2-linter: disable=[name/workflow-file][name/struct] |
Collaborator
There was a problem hiding this comment.
What is the reason to disable the tests here?
| }; // class hyperNucCandidate | ||
| KFParticle getDaughterTrackKfp(int track) | ||
| { | ||
| return kfpDaughters.at(track + isCascade() ? 1 : 0); |
Collaborator
There was a problem hiding this comment.
This is a bug reported as a compilation error. Please fix it asap.
Contributor
Author
|
Dear Vit,
I have just committed a bug fix.
Best regards, Michael
Am Mittwoch, dem 18.12.2024 um 11:16 -0800 schrieb Vít Kučera:
… @vkucera commented on this pull request.
@mhartung71 Thanks a lot for addressing the O2 linter warnings.
Please see my comments below.
In PWGLF/TableProducer/Nuspex/hypKfRecoTask.cxx:
> -struct hypKfRecoTask {
+struct hypKfRecoTask { // o2-linter: disable=[name/workflow-
file][name/struct]
What is the reason to disable the tests here?
In PWGLF/TableProducer/Nuspex/hypKfRecoTask.cxx:
> @@ -369,32 +348,46 @@ struct hyperNucCandidate {
subDaughter.TransportToDecayVertex();
return subDaughter.GetMass();
}
-}; // class hyperNucCandidate
+ KFParticle getDaughterTrackKfp(int track)
+ {
+ return kfpDaughters.at(track + isCascade() ? 1 : 0);
This is a bug reported as a compilation error. Please fix it asap.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Merged
Collaborator
|
Thanks @mhartung71 |
hernasab
pushed a commit
to hernasab/O2Physics
that referenced
this pull request
Dec 20, 2024
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
feisenhu
pushed a commit
to feisenhu/O2Physics
that referenced
this pull request
Jan 8, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Feb 17, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.