Skip to content

[Common] Fix compilation warnings #8379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddobrigk merged 2 commits into from
Nov 14, 2024
Merged

[Common] Fix compilation warnings #8379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2047d1c
Fix compilation warnings
vkucera Nov 11, 2024
9da1070
Include vector header
vkucera Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Common/Core/TPCVDriftManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ class TPCVDriftManager
if (dDriftErr < 0.f || dDrift > 250.f) { // we cannot move a track outside the drift volume
if (mOutside < mWarningLimit) {
LOGP(warn, "Skipping correction outside of tpc volume with dDrift={} +- {}", dDrift, dDriftErr);
const auto& trackBC = trackExtra.template collision_as<Collisions>().template foundBC_as<BCs>().globalBC();
const auto& colBC = col.template foundBC_as<BCs>().globalBC();
const auto trackBC = trackExtra.template collision_as<Collisions>().template foundBC_as<BCs>().globalBC();
const auto colBC = col.template foundBC_as<BCs>().globalBC();
int diffBC = colBC - trackBC;
LOGP(info, "ct={}; ctr={}; tTB={}; t0={}; dTime={}; dDrift={}; tgl={}: colBC={} trackBC={} diffBC={}", col.collisionTime(), col.collisionTimeRes(), tTB, trackExtra.trackTime(), dTime, dDrift, track.getTgl(), colBC, trackBC, diffBC);
if (mOutside == mWarningLimit - 1) {
Expand Down
2 changes: 1 addition & 1 deletion Common/TableProducer/Converters/bcFlagsCreator.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ struct bcFlagsCreator {

void process(aod::BCs const& bcTable)
{
for (auto& _ : bcTable) {
for (int64_t i = 0; i < bcTable.size(); ++i) {
bcFlags(0);
}
}
Expand Down
7 changes: 4 additions & 3 deletions Common/TableProducer/mcCollsExtra.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@
// Quick and dirty task to correlate MC <-> data
//

#include <cmath>
#include <array>
#include <cmath>
#include <cstdlib>
#include <vector>

#include "Math/Vector4D.h"
#include <TFile.h>
Expand Down Expand Up @@ -135,8 +136,8 @@ struct mcCollisionExtra {
auto iter = std::find(sortedIndices.begin(), sortedIndices.end(), mcCollision.index());
if (iter != sortedIndices.end()) {
auto index = std::distance(iter, sortedIndices.begin());
for (size_t iMcColl = index + 1; iMcColl < index + 17; iMcColl++) {
if (iMcColl >= sortedIndices.size())
for (auto iMcColl = index + 1; iMcColl < index + 17; iMcColl++) {
if (iMcColl >= std::ssize(sortedIndices))
continue;
if (mcCollisionHasPoI[sortedIndices[iMcColl]])
bitset(forwardHistory, iMcColl - index - 1);
Expand Down