PIDML: evaluate FSE + self-attention network#7162
Merged
saganatt merged 6 commits intoAliceO2Group:masterfrom Aug 7, 2024
Merged
PIDML: evaluate FSE + self-attention network#7162saganatt merged 6 commits intoAliceO2Group:masterfrom
saganatt merged 6 commits intoAliceO2Group:masterfrom
Conversation
* remove detector count setting and reorder network arguments (with NaNs if detector not available) * update README.md * markdownlint changes
Collaborator
|
Error while checking build/O2Physics/o2 for 6bafb63 at 2024-08-05 16:28: Full log here. |
saganatt
requested changes
Aug 6, 2024
Collaborator
saganatt
left a comment
saganatt
left a comment
There was a problem hiding this comment.
Thanks a lot for upgrading the code.
Here is my batch of comments.
saganatt
approved these changes
Aug 6, 2024
Luca610
pushed a commit
to Luca610/O2Physics
that referenced
this pull request
Aug 13, 2024
* PIDML evaluate FSE + self-attention network (#5) * remove detector count setting and reorder network arguments (with NaNs if detector not available) * update README.md * markdownlint changes * MegaLinter fixes (#6) * fix include missing file, the same way it was before * readd pLimits to ONNXinterface and pass it to ONNXmodel * Please consider the following formatting changes (#9) * improve qaPidML according to new approach --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
joonsukbae
pushed a commit
to joonsukbae/O2Physics
that referenced
this pull request
Aug 27, 2024
* PIDML evaluate FSE + self-attention network (#5) * remove detector count setting and reorder network arguments (with NaNs if detector not available) * update README.md * markdownlint changes * MegaLinter fixes (#6) * fix include missing file, the same way it was before * readd pLimits to ONNXinterface and pass it to ONNXmodel * Please consider the following formatting changes (AliceO2Group#9) * improve qaPidML according to new approach --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove detector count setting and reorder network arguments (with NaNs if detector not available)
update README.md
markdownlint changes