[event plane] fix bug #6788
Merged
[event plane] fix bug #6788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 9, 2024 19:45
jikim1290
requested review from
a team,
alibuild,
ddobrigk,
iarsene,
jgrosseo and
ktf
as code owners
Collaborator
|
Dear @strogolo and @ddobrigk , It was me who spotted this. Last week, @jikim1290 explained to me that BPos is measured in 0.1 < eta < 0.8, BNeg is measured in -0.8 < eta < -0.1, and BTot is measured in - 0.8 < eta < 0.8. But, I found that code is inconsistent with his explanation. So, can you also check which eta cut is applied to tracks during the calibration? Thank you. |
ddobrigk
approved these changes
Jul 9, 2024
Collaborator
ddobrigk
left a comment
ddobrigk
left a comment
There was a problem hiding this comment.
Looks good, thanks!
And the conclusion of the story is: continue is to be used with care (it's easy to slip up with this indeed :-D )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug