Skip to content

Conversation

@AlexianL
Copy link
Contributor

@AlexianL AlexianL commented May 16, 2024

Few minor changes too : change of the default axisMass binning, typo correction, re-organization of the AnalysisResults root file, renaming of "MyCollisions" and "MyTracks" by more comprehensive names.

@vkucera vkucera changed the title PWGHF : taskFlow.cxx -> adding mixed-event process function for the h-MFT case PWGHF: taskFlow.cxx: Add mixed-event process function for h-MFT May 21, 2024
… changed the organization of the AnalysisResults root file
@fgrosa
Copy link
Collaborator

fgrosa commented May 29, 2024

@NicoleBastid @mmazzilli @deepathoms could you please have a look? Thanks!

Copy link
Collaborator

@mmazzilli mmazzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine with me. My only suggestion is to use a better naming wrt "MyCollisions" and "MyTracks"

@Katka19
Copy link
Contributor

Katka19 commented May 30, 2024

Hi Marianna, thanks a lot for checking the PR. I see that the change to "MyCollisions" was done in this HF-wide PR: #3454 . So maybe this is how it should be? I don't have a strong preference, so I can check how the naming should be and we can change it if needed.

@vkucera
Copy link
Collaborator

vkucera commented May 30, 2024

Hi Marianna, thanks a lot for checking the PR. I see that the change to "MyCollisions" was done in this HF-wide PR: #3454 . So maybe this is how it should be? I don't have a strong preference, so I can check how the naming should be and we can change it if needed.

How about FilteredCollisionsWSelMult, TracksWDcaSel?

@mmazzilli
Copy link
Collaborator

Hi Marianna, thanks a lot for checking the PR. I see that the change to "MyCollisions" was done in this HF-wide PR: #3454 . So maybe this is how it should be? I don't have a strong preference, so I can check how the naming should be and we can change it if needed.

Hi Katarina,
indeed this was not something introduced with this PR but it was a good occasion to take care of it. Thanks to @vkucera for the suggestion and to @AlexianL for the implementation. As soon as the MegaLinter issue is solved, I will approve the PR.

@mmazzilli mmazzilli enabled auto-merge (squash) May 31, 2024 08:29
@mmazzilli mmazzilli merged commit 54040dd into AliceO2Group:master Jun 4, 2024
nasirmehdimalik pushed a commit to nasirmehdimalik/O2Physics that referenced this pull request Jun 6, 2024
…eO2Group#6177)

* Added h-MFT mixed event process function, trying to artificially fill multiplicity bins

* taskFlow.cxx : adding mixed-event process function for h-MFT case

* taskFlow.cxx : adding mixed-event process function for h-MFT case

* PWGHF : taskFlow.cxx -> adding mixed-event process function for h-MFT case

* PWGHF : taskFlow.cxx -> adding mixed-event process function for h-MFT case

* PWGHF : taskFlow.cxx -> adding mixed-event process function for h-MFT case

* Correct a mistake in the Mixed Event process function for h-MFT, also changed the organization of the AnalysisResults root file

* Replaced MyCollisions and MyTracks by more comprehensive variable names

* Attempt to fix megalinter issue by adding an empty line at the end of the file
@AlexianL AlexianL deleted the mixed_event_MFT branch June 19, 2024 12:41
GiorgioAlbertoLucia pushed a commit to GiorgioAlbertoLucia/O2Physics that referenced this pull request Jul 9, 2024
…eO2Group#6177)

* Added h-MFT mixed event process function, trying to artificially fill multiplicity bins

* taskFlow.cxx : adding mixed-event process function for h-MFT case

* taskFlow.cxx : adding mixed-event process function for h-MFT case

* PWGHF : taskFlow.cxx -> adding mixed-event process function for h-MFT case

* PWGHF : taskFlow.cxx -> adding mixed-event process function for h-MFT case

* PWGHF : taskFlow.cxx -> adding mixed-event process function for h-MFT case

* Correct a mistake in the Mixed Event process function for h-MFT, also changed the organization of the AnalysisResults root file

* Replaced MyCollisions and MyTracks by more comprehensive variable names

* Attempt to fix megalinter issue by adding an empty line at the end of the file
echizzal pushed a commit to echizzal/O2Physics that referenced this pull request Jul 18, 2024
…eO2Group#6177)

* Added h-MFT mixed event process function, trying to artificially fill multiplicity bins

* taskFlow.cxx : adding mixed-event process function for h-MFT case

* taskFlow.cxx : adding mixed-event process function for h-MFT case

* PWGHF : taskFlow.cxx -> adding mixed-event process function for h-MFT case

* PWGHF : taskFlow.cxx -> adding mixed-event process function for h-MFT case

* PWGHF : taskFlow.cxx -> adding mixed-event process function for h-MFT case

* Correct a mistake in the Mixed Event process function for h-MFT, also changed the organization of the AnalysisResults root file

* Replaced MyCollisions and MyTracks by more comprehensive variable names

* Attempt to fix megalinter issue by adding an empty line at the end of the file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants