[PWGDQ] New analysis task for asymmetric barrel pairs. Implement reduced ZDC table.#5948
[PWGDQ] New analysis task for asymmetric barrel pairs. Implement reduced ZDC table.#5948iarsene merged 6 commits intoAliceO2Group:masterfrom
Conversation
Implement reduced ZDC table, which is filled in table-maker-with-assoc
Please consider the following formatting changes to AliceO2Group#5948
| VarManager::fgValues[VarManager::kTimestamp] = bc.timestamp(); | ||
| VarManager::fgValues[VarManager::kRunIndex] = VarManager::GetRunIndex(bc.runNumber()); | ||
| VarManager::FillEvent<TEventFillMap>(collision); // extract event information and place it in the fValues array | ||
| if constexpr ((TEventFillMap & VarManager::ObjTypes::Zdc) > 0) { |
There was a problem hiding this comment.
Open to cosmetic changes and suggestions regarding this block. Maybe there is somewhere better to put this?
There was a problem hiding this comment.
I think its fine like this
| VarManager::fgValues[VarManager::kTimestamp] = bc.timestamp(); | ||
| VarManager::fgValues[VarManager::kRunIndex] = VarManager::GetRunIndex(bc.runNumber()); | ||
| VarManager::FillEvent<TEventFillMap>(collision); // extract event information and place it in the fValues array | ||
| if constexpr ((TEventFillMap & VarManager::ObjTypes::Zdc) > 0) { |
There was a problem hiding this comment.
I think its fine like this
| fHistMan->FillHistClass(histNames[icut][8].Data(), VarManager::fgValues); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The split of the histogramming for in bunch and out of bunch ambiguity could be useful, but if you didn't wanted it for now, you don't have to add it. In my case, for the same-event pairing, i had to understand a bit some of the effects on jpsi. But anyway, i think it might be useful for you as well. So maybe leave it as it is.
sigurdnese
requested review from
alibuild,
dsekihat,
feisenhu and
lucamicheletti93
as code owners
|
This PR is modifying the reduced data model file, by adding a table with ZDC information. We agreed today at the O2 DQ to have discussions in the meeting before touching core aspects of the framework, such as core workflows or the data model. However, because there is a time component for this case, and because it just adds a new table (not modifying an old one), i approved and merged this PR. |
…ced ZDC table. (AliceO2Group#5948) * New analysis task for asymmetric barrel pairs, e.g. D0->K-pi+ Implement reduced ZDC table, which is filled in table-maker-with-assoc * Remove debug histograms * Please consider the following formatting changes * MegaLinter comments * More MegaLinter comments --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…ced ZDC table. (AliceO2Group#5948) * New analysis task for asymmetric barrel pairs, e.g. D0->K-pi+ Implement reduced ZDC table, which is filled in table-maker-with-assoc * Remove debug histograms * Please consider the following formatting changes * MegaLinter comments * More MegaLinter comments --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
3 participants
Implement reduced ZDC table, which is filled in table-maker-with-assoc.
New analysis task for asymmetric barrel pairs, e.g. D0->K-pi+.