support for NUA, part 2 (the custom case)#5935
Merged
victor-gonzalez merged 2 commits intoAliceO2Group:masterfrom May 2, 2024
abilandz:master
Merged
support for NUA, part 2 (the custom case)#5935victor-gonzalez merged 2 commits intoAliceO2Group:masterfrom abilandz:master
victor-gonzalez merged 2 commits intoAliceO2Group:masterfrom
abilandz:master
Conversation
abilandz
requested review from
alibuild,
saganatt,
victor-gonzalez and
zchochul
as code owners
Comment on lines
+5202
to
+5203
| if (!(TString(variable).EqualTo("phi") || TString(variable).EqualTo("pt") || TString(variable).EqualTo("eta"))) { | ||
| LOGF(fatal, "in function \033[1;31m%s at line %d\033[0m", __FUNCTION__, __LINE__); |
Collaborator
There was a problem hiding this comment.
This is quite expensive execution wise. I hope you are not calling this from inner loops
For the next iteration consider using an enum for the kind of variable you are passing
With enum values you just compare two numbers. With strings you have to go character by character
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback, noted! In most cases like this I switched to enums , but this one I overlooked! To be fixed alongside the next PR.
victor-gonzalez
approved these changes
May 2, 2024
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 7, 2024
* support for NUA, part 2 (the custom case) * fix for MegaLinter
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
* support for NUA, part 2 (the custom case) * fix for MegaLinter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.