PWGHF: Implement other channels for omegac0 in candidateCreator by ZFederica · Pull Request #5893 · AliceO2Group/O2Physics

ZFederica · 2024-04-29T11:28:00Z

Hello @fgrosa, is this implementation similar to the one you had in mind?

Please consider the following formatting changes to AliceO2Group#5893

… working

Please consider the following formatting changes to AliceO2Group#5893

fgrosa

Hi @ZFederica thanks a lot for the development! I have a few comments before merging, see below

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

vkucera · 2024-05-10T08:31:05Z

Converting to draft as there seems to be work in progress. Please keep in mind that every time you update the PR, you ask the CI to run a new build.

ZFederica · 2024-05-10T08:36:14Z

Hi @vkucera, this PR is ready for review - I have implemented all the requested changes. I was just wondering how I could resolve the merge conflicts: the new version of the code already takes into account and implements the bug fix that created the conflict, but that function changed a lot

vkucera · 2024-05-10T10:08:18Z

Hi @vkucera, this PR is ready for review - I have implemented all the requested changes. I was just wondering how I could resolve the merge conflicts: the new version of the code already takes into account and implements the bug fix that created the conflict, but that function changed a lot

Hi @ZFederica , you have to merge the upstream/master branch into your branch.

alibuild · 2024-05-10T12:52:23Z

Error while checking build/O2Physics/o2 for a885973 at 2024-05-10 14:52:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/5893-slc7_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1050:74: error: no matching function for call to 'HfCandidateCreatorXic0Omegac0Mc::runXic0Omegac0Mc<o2::aod::hf_cand_xic0_omegac0::XiczeroToXiPi>(const o2::aod::HfCandToXiPi&, const o2::aod::TracksWMc&, const o2::aod::McParticles&, const o2::aod::McCollisionLabels&)'
/sw/SOURCES/O2Physics/5893-slc7_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1059:77: error: no matching function for call to 'HfCandidateCreatorXic0Omegac0Mc::runXic0Omegac0Mc<o2::aod::hf_cand_xic0_omegac0::OmegaczeroToXiPi>(const o2::aod::HfCandToXiPi&, const o2::aod::TracksWMc&, const o2::aod::McParticles&, const o2::aod::McCollisionLabels&)'
/sw/SOURCES/O2Physics/5893-slc7_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1068:80: error: no matching function for call to 'HfCandidateCreatorXic0Omegac0Mc::runXic0Omegac0Mc<o2::aod::hf_cand_xic0_omegac0::OmegaczeroToOmegaPi>(const o2::aod::HfCandToOmegaPi&, const o2::aod::TracksWMc&, const o2::aod::McParticles&, const o2::aod::McCollisionLabels&)'
/sw/SOURCES/O2Physics/5893-slc7_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:1077:79: error: no matching function for call to 'HfCandidateCreatorXic0Omegac0Mc::runXic0Omegac0Mc<o2::aod::hf_cand_xic0_omegac0::OmegaczeroToOmegaK>(const o2::aod::HfCandToOmegaK&, const o2::aod::TracksWMc&, const o2::aod::McParticles&, const o2::aod::McCollisionLabels&)'
ninja: build stopped: subcommand failed.

Full log here.

fgrosa · 2024-05-10T13:17:16Z

Hi @ZFederica once resolved the conflicts it's good for me. Thanks!

Please consider the following formatting changes to AliceO2Group#5893

…eO2Group#5893) * Implement other channels * Add note * Continue implementation * Update * Fix build errors * Please consider the following formatting changes * Fix check on enabled processes * Please consider the following formatting changes * Fix megalinter error * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Remove dupl var massPDG * Switch double -> float * Remove hfflags * Double->float also in treecreator * Update * Update namespace as requested in other PR * Update * Fix build error * Fix conflicts * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

…eO2Group#5893) * Implement other channels * Add note * Continue implementation * Update * Fix build errors * Please consider the following formatting changes * Fix check on enabled processes * Please consider the following formatting changes * Fix megalinter error * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch> * Remove dupl var massPDG * Switch double -> float * Remove hfflags * Double->float also in treecreator * Update * Update namespace as requested in other PR * Update * Fix build error * Fix conflicts * Please consider the following formatting changes --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Implement other channels

ed4d50c

ZFederica requested review from NicoleBastid, alibuild, deepathoms, fcatalan92, fcolamar, fgrosa, hahassan7, mfaggin, mmazzilli, nzardosh and vkucera as code owners April 29, 2024 11:28

ZFederica marked this pull request as draft April 29, 2024 11:28

ZFederica and others added 6 commits April 29, 2024 13:47

Add note

a9fccaf

Continue implementation

a0197c4

Update

b66d4e3

Fix build errors

4dfbbe3

Please consider the following formatting changes

34cd0d0

Merge pull request #78 from alibuild/alibot-cleanup-5893

8bad0a6

Please consider the following formatting changes to AliceO2Group#5893

ZFederica marked this pull request as ready for review May 6, 2024 13:29

ZFederica and others added 5 commits May 6, 2024 16:07

Fix check on enabled processes

ea82bd2

Merge branch 'working' of https://github.com/ZFederica/O2Physics into…

2b8eca0

… working

Please consider the following formatting changes

9b75bd1

Merge pull request #79 from alibuild/alibot-cleanup-5893

0aedeaa

Please consider the following formatting changes to AliceO2Group#5893

Fix megalinter error

4c5e426

fgrosa requested changes May 9, 2024

View reviewed changes

ZFederica and others added 4 commits May 10, 2024 09:42

Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

ab7b280

Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

646decd

Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

633c680

Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

d553ac9

Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>

Remove dupl var massPDG

2bd92bf

ZFederica requested a review from jpxrk as a code owner May 10, 2024 07:55

ZFederica added 4 commits May 10, 2024 10:02

Switch double -> float

7c959a1

Remove hfflags

5c412dd

Double->float also in treecreator

981fe28

Update

4244d9c

vkucera marked this pull request as draft May 10, 2024 08:31

Update namespace as requested in other PR

a94c392

vkucera marked this pull request as ready for review May 10, 2024 10:05

ZFederica added 2 commits May 10, 2024 13:54

Update

f372ab3

Update with master

a885973

Fix build error

81f635d

ZFederica and others added 4 commits May 10, 2024 15:37

Fix conflicts

1b7ca81

Fix conflicts

26da1ec

Please consider the following formatting changes

975b7e5

Merge pull request #83 from alibuild/alibot-cleanup-5893

51510a9

Please consider the following formatting changes to AliceO2Group#5893

fgrosa approved these changes May 10, 2024

View reviewed changes

fgrosa enabled auto-merge (squash) May 10, 2024 15:12

fgrosa merged commit 8aaa5ea into AliceO2Group:master May 10, 2024

ZFederica deleted the working branch May 13, 2024 09:00

vkucera reviewed May 13, 2024

View reviewed changes

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Show resolved Hide resolved

vkucera reviewed May 13, 2024

View reviewed changes

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Show resolved Hide resolved

ZFederica mentioned this pull request May 14, 2024

PWGHF: implement requested changes in old PR omegac xic #6139

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PWGHF: Implement other channels for omegac0 in candidateCreator#5893

PWGHF: Implement other channels for omegac0 in candidateCreator#5893
fgrosa merged 29 commits intoAliceO2Group:masterfrom
ZFederica:working

ZFederica commented Apr 29, 2024

Uh oh!

fgrosa left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera commented May 10, 2024

Uh oh!

ZFederica commented May 10, 2024 •

edited

Loading

Uh oh!

vkucera commented May 10, 2024

Uh oh!

alibuild commented May 10, 2024

Uh oh!

fgrosa commented May 10, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

ZFederica commented Apr 29, 2024

Uh oh!

fgrosa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vkucera commented May 10, 2024

Uh oh!

ZFederica commented May 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented May 10, 2024

Uh oh!

alibuild commented May 10, 2024

Uh oh!

fgrosa commented May 10, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

ZFederica commented May 10, 2024 •

edited

Loading