Skip to content

PWGHF: Use pVector instead of std::array{px, py, pz}#5710

Merged
fgrosa merged 12 commits intoAliceO2Group:masterfrom
vkucera:pvec
Apr 22, 2024
Merged

PWGHF: Use pVector instead of std::array{px, py, pz}#5710
fgrosa merged 12 commits intoAliceO2Group:masterfrom
vkucera:pvec

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Apr 19, 2024

  • Simplifies code by using pVector columns from Tracks, McParticles and ReducedDataModel.h tables instead of
    explicitly constructing arrays from px, py, pz.
  • Simplifies calculations with momenta, using proper RecoDecay functions.
  • Limits the scope of some local variables in trackIndexSkimCreator.cxx.

Requires:

Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vkucera it looks good to me (I hope I did not overlooked any instance), thanks a lot!

@fgrosa fgrosa merged commit 55cebdd into AliceO2Group:master Apr 22, 2024
@vkucera vkucera deleted the pvec branch April 22, 2024 15:43
christianreckziegel pushed a commit to christianreckziegel/O2Physics that referenced this pull request May 2, 2024
…p#5710)

* Get momentum vector in one go. Avoid unnecessary calculations

* Add pVector

* Add pVector in the ReducedDataModel

* Add pVector in ReducedDataModel for static px,py,pz

* Use pVector for McParticles

* Use pVector for particle daughters

* Use pVector in calculations

* EventFiltering

* Please consider the following formatting changes (AliceO2Group#69)

---------

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request May 17, 2024
…p#5710)

* Get momentum vector in one go. Avoid unnecessary calculations

* Add pVector

* Add pVector in the ReducedDataModel

* Add pVector in ReducedDataModel for static px,py,pz

* Use pVector for McParticles

* Use pVector for particle daughters

* Use pVector in calculations

* EventFiltering

* Please consider the following formatting changes (AliceO2Group#69)

---------

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants