PWGHF: make uniform event selection #5261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgrosa
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
mfaggin,
mmazzilli,
nzardosh and
vkucera
as code owners
Please consider the following formatting changes to AliceO2Group#5261
vkucera
reviewed
Mar 20, 2024
vkucera
reviewed
Mar 20, 2024
vkucera
requested changes
Mar 20, 2024
Please consider the following formatting changes to AliceO2Group#5261
Collaborator
Author
|
Hi @vkucera thanks for your comments! I have implemented them and also restored the possibility to apply the |
Please consider the following formatting changes to AliceO2Group#5261
vkucera
reviewed
Mar 20, 2024
vkucera
reviewed
Mar 20, 2024
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
fgrosa
requested review from
BongHwi,
chiarapinto,
ercolessi,
fmazzasc and
mbombara
as code owners
fgrosa
requested review from
a team,
afurs,
ddobrigk,
jgrosseo,
ktf,
mpuccio,
saganatt,
strogolo,
victor-gonzalez,
zchochul and
zhangbiao-phy
as code owners
vkucera
reviewed
Mar 20, 2024
vkucera
requested changes
Mar 20, 2024
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Please consider the following formatting changes to AliceO2Group#5261
vkucera
requested changes
Mar 20, 2024
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
May 2, 2024
* PWGHF: make uniform event selection * Please consider the following formatting changes * Implement Vit's comments and restore possibility to select Run2 trigger class * Please consider the following formatting changes * Implement Vit's comments * Please consider the following formatting changes * Update PWGHF/Utils/utilsEvSelHf.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * Fix copy-paste mistake * Trivial commit * Change type in data model * Improve histo title * Document template parameters * Update PWGHF/Utils/utilsEvSelHf.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * Update PWGHF/Utils/utilsEvSelHf.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * Please consider the following formatting changes * Update PWGHF/Utils/utilsEvSelHf.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
May 17, 2024
* PWGHF: make uniform event selection * Please consider the following formatting changes * Implement Vit's comments and restore possibility to select Run2 trigger class * Please consider the following formatting changes * Implement Vit's comments * Please consider the following formatting changes * Update PWGHF/Utils/utilsEvSelHf.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * Fix copy-paste mistake * Trivial commit * Change type in data model * Improve histo title * Document template parameters * Update PWGHF/Utils/utilsEvSelHf.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * Update PWGHF/Utils/utilsEvSelHf.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> * Please consider the following formatting changes * Update PWGHF/Utils/utilsEvSelHf.h Co-authored-by: Vít Kučera <vit.kucera@cern.ch> --------- Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mfaggin, @vkucera, as promised I modified the track-index-skim creator using the event selection utilities developed for the creators. The main changes are:
trackIndexSkimCreator(I do not see why we should do it)trackIndexSkimCreatorto match the one in the creatorsZvtxat the end of the selections (to have theZvtxcut efficiency only for selected events)HistogramRegistryin the creators