Fix namespace pollution from std and o2::constants
#3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2023
vkucera
requested review from
alibuild,
lramona,
lbariogl,
chiarapinto,
BongHwi,
mbombara,
iravasen,
njacazio,
ChiaraDeMartin95,
skundu692,
fcolamar,
adubla,
fcatalan92,
lvermunt,
mikesas and
rbailhac
as code owners
vkucera
requested review from
jgrosseo,
saganatt,
victor-gonzalez,
zchochul,
fgrosa,
mpuccio,
strogolo,
mfaggin,
ktf,
ddobrigk and
a team
as code owners
njacazio
reviewed
Sep 5, 2023
| @@ -31,6 +31,7 @@ | |||
| // | |||
| // base namespaces | |||
| using namespace o2; | |||
| using namespace o2::constants::math; | |||
There was a problem hiding this comment.
Hi Vit, thanks a lot! Just for me to understand, is this now needed because of a change in the includes?
There was a problem hiding this comment.
Hi @njacazio , yes, this one in particular is a fix of pollution from Framework/AnalysisDataModel.h (see https://github.com/AliceO2Group/AliceO2/pull/11851/files#diff-6410cfe670c62cda55ab26854e52f05a3b75d325cb663e7852d79df3d4bad58e).
njacazio
approved these changes
Sep 5, 2023
saganatt
approved these changes
Sep 5, 2023
mikesas
approved these changes
Sep 5, 2023
fcatalan92
approved these changes
Sep 5, 2023
iarsene
approved these changes
Sep 6, 2023
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 6, 2023
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 7, 2023
samrangy
pushed a commit
to samrangy/O2Physics
that referenced
this pull request
Oct 11, 2023
zconesa
pushed a commit
to zconesa/O2Physics
that referenced
this pull request
Oct 27, 2023
chengtt0406
pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove using directives in headers polluting the namespace with names from
stdando2::constants.