[PWGLF] Configurables for eta range selection and THnSparse in spectarTOF.cxx #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloemker
requested review from
alibuild,
lramona,
lbariogl,
chiarapinto,
BongHwi,
mbombara,
iravasen,
njacazio,
ChiaraDeMartin95 and
skundu692
as code owners
njacazio
reviewed
Jul 12, 2023
PWGLF/Tasks/spectraTOF.cxx
Outdated
| @@ -44,7 +44,9 @@ using namespace o2::framework::expressions; | |||
| struct tofSpectra { | |||
| Configurable<float> cfgNSigmaCut{"cfgNSigmaCut", 3, "Value of the Nsigma cut"}; | |||
| Configurable<float> cfgCutVertex{"cfgCutVertex", 10.0f, "Accepted z-vertex range"}; | |||
| Configurable<float> cfgCutEta{"cfgCutEta", 0.8f, "Eta range for tracks"}; | |||
| Configurable<float> cfgCutEtaMax{"cfgCutEtaMax", 0.8f, "Max eta range for tracks"}; | |||
| Configurable<float> cfgCutEtaMin{"cfgCutEtaMin", 0.8f, "Min eta range for tracks"}; | |||
There was a problem hiding this comment.
Hi @jloemker can't you remove the absolute value in the check and put -0.8 in the configurable, it's not obvious that it will be symmetrical
There was a problem hiding this comment.
Hi @njacazio ,
I included your suggestion and added one more histogram for the eta distribution of the tracks in the collision (processDerived).
Many Thanks !
njacazio
previously approved these changes
Jul 12, 2023
auto-merge was automatically disabled
July 12, 2023 16:47
Head branch was pushed to by a user without write access
|
I think CI is spurious |
njacazio
approved these changes
Jul 13, 2023
joonsukbae
pushed a commit
to joonsukbae/O2Physics
that referenced
this pull request
Jul 14, 2023
…rTOF.cxx (AliceO2Group#3047) * confugurables for eta range and THnSparse * clang formatting for PR * include suggestions for eta range and eta track histogram * Extend binning of nsigma - Streamline * fix dervied tables * adjust max,min binning --------- Co-authored-by: Nicolò Jacazio <nicolo.jacazio@cern.ch>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 6, 2023
…rTOF.cxx (AliceO2Group#3047) * confugurables for eta range and THnSparse * clang formatting for PR * include suggestions for eta range and eta track histogram * Extend binning of nsigma - Streamline * fix dervied tables * adjust max,min binning --------- Co-authored-by: Nicolò Jacazio <nicolo.jacazio@cern.ch>
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Oct 7, 2023
…rTOF.cxx (AliceO2Group#3047) * confugurables for eta range and THnSparse * clang formatting for PR * include suggestions for eta range and eta track histogram * Extend binning of nsigma - Streamline * fix dervied tables * adjust max,min binning --------- Co-authored-by: Nicolò Jacazio <nicolo.jacazio@cern.ch>
zconesa
pushed a commit
to zconesa/O2Physics
that referenced
this pull request
Oct 27, 2023
…rTOF.cxx (AliceO2Group#3047) * confugurables for eta range and THnSparse * clang formatting for PR * include suggestions for eta range and eta track histogram * Extend binning of nsigma - Streamline * fix dervied tables * adjust max,min binning --------- Co-authored-by: Nicolò Jacazio <nicolo.jacazio@cern.ch>
chengtt0406
pushed a commit
to chengtt0406/O2Physics
that referenced
this pull request
Dec 6, 2023
…rTOF.cxx (AliceO2Group#3047) * confugurables for eta range and THnSparse * clang formatting for PR * include suggestions for eta range and eta track histogram * Extend binning of nsigma - Streamline * fix dervied tables * adjust max,min binning --------- Co-authored-by: Nicolò Jacazio <nicolo.jacazio@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @njacazio ,
here are two additional configurables to select a certain eta range for the analysis and the modification for the nsigmaTPCTOF to use the THnSparse.
Let me know if I should change something (or add more to the task).
Best,
Johanna