Use O2-like 4-space indents in JSON files #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure clang-format to format JSON files like O2 would dump them, i.e. with 4-space indents. This way, we can track O2-generated JSON files in the repo directly, without having to reformat them.
TimoWilken
requested review from
a team,
alibuild,
jgrosseo,
iarsene,
ktf and
ddobrigk
as code owners
|
Thanks @TimoWilken ! |
ddobrigk
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure clang-format to format JSON files like O2 would dump them, i.e. with 4-space indents. This way, we can track O2-generated JSON files in the repo directly, without having to reformat them.
Tested with an existing JSON file in the O2Physics repo; seems to work.
This came up in #2445.