PWGHF: Implementation of Event mixing for D+-hadron Correlation #2329
PWGHF: Implementation of Event mixing for D+-hadron Correlation #2329vkucera merged 23 commits intoAliceO2Group:masterfrom
Conversation
|
Please fix the formatting by merging the automatic PR (as explained in the contribution documentation). |
Thank you for pointing out I was doing it manually by looking at one by one. It will be very helpful. |
Please consider the following formatting changes to AliceO2Group#2329
vkucera
left a comment
There was a problem hiding this comment.
There is const missing in many loops.
|
Error while checking build/O2Physics/o2 for 791bef7 at 2023-04-28 07:43: Full log here. |
|
Hi @Simple-Shyam , I don't see any update since my review and the code does not compile. What is the status? |
The code compiled initially, but then there is a slice cache method pushed on the repository, and then it doesn't compile because of this new method. I implemented the comments and slice cache method, and then there was an issue with findBin (returning an unknown number), which I reported on Mattermost. I updated O2Physics, and it fixes the findBin issue. I am currently checking the results' compatibility and will commit it again in a few days. |
OK, no problem. Next time when you expect to take several days to update the PR, please convert it into a draft until you push new commits. |
Please consider the following formatting changes to AliceO2Group#2561
|
Hi @Simple-Shyam , can you please explain why you closed this PR and opened a new identical one? #2561 |
Thanks Vit, I implemented the comments, you mentioned above. I also added the event mixing for the MCGen mode. I didn't close it. I just updated my local repository before committing the new locally compiled codes with recent O2Physics, and then the pull request is automatically de-attached from my local repository and marked as close. I don't know what is the proper solution in that case, so I created a fresh pull request. You can suggest me the best solution in this case. |
Please consider the following formatting changes to AliceO2Group#2329
Hi @Simple-Shyam , several comments are still not addressed. |
Please consider the following formatting changes to AliceO2Group#2329
|
Ciao @Simple-Shyam, I see that you pushed further updates, but without commenting: do you confirm that you took into consideration the remaining comments by @vkucera, or is something still remaining? Can we in the former case proceed forward? |
Ciao @fcolamar yes, I updated the code implementing the comments and informed @vkucera in matter-most in the personal message. I was waiting for reply. In the mean time base CandidateReconstructionTables.h class is changed. I have to start with the new CandidateReconstructionTables.h again. I push a new commit after fixing of comments. Thank you |
Please consider the following formatting changes to AliceO2Group#2329
|
Hi @Simple-Shyam , there are still pending comments, that have not been addressed. |
Thanks, Can you please highlight the comment/comments? Next time I would try to do shorter commit. Is there any way, I can check which comment is not addressed. I am a bit confused why comments are missing from me? I read two times. |
You see that the comments on this page marked as resolved are collapsed. The unresolved comments are still fully visible. |
I fixed the recent comment to sort all the includes w.r.t. directories and also double changed to float as suggested at line 72-73.
Thanks now it's clear. I need to check the flag that can tell me the situation. I am not very much expert so taking time. |
I have just a question for my understanding. This marking as resolved is automatic or you flag them after reviewing? |
I flag them as resolved when the comments is addressed properly. |
vkucera
left a comment
There was a problem hiding this comment.
Thanks @Simple-Shyam , it looks fine to me.
@mmazzilli @deepathoms please have a look.
Thank you @vkucera for helping to learn the things. |
|
The commit looks good for me. Green light to merge it. |
I implemented the event mixing for D+-hadron correlation in Data and MCRec mode.