Skip to content

Conversation

@lauraser
Copy link
Collaborator

@lauraser lauraser commented Oct 9, 2021

The class is performing the close pair rejection check for particle pairs.

@lauraser lauraser requested review from a team, iarsene, jgrosseo and ktf as code owners October 9, 2021 01:52
@jgrosseo
Copy link
Contributor

Hi Laura.
Is this your own implementation because what I had in PairCuts.h is not sufficient? What was missing and can we provide a generic solution also for other analyzers?

@lauraser
Copy link
Collaborator Author

Dear Jan,

the main differences are that:

  • in our case, the decision is made by comparing the average dphi, not the min dphi,
  • we have our own choice of the array of radii for which we calculate the phi,
  • for debugging we will use the 2D histograms created for every radii (which is a hardcoded array mentioned in the second bullet point).

We cannot confirm that this will be as well our final solution for Run3 as we have to test if the same approach works on real data. However, we must validate our codes by comparing AliPhysics results with our new implementation in O2, and thus we need exact replica of the tasks we currently have in AliPhysics.

@lauraser
Copy link
Collaborator Author

Our implementation as well deals separately with different candidates. For example, if the function is called for track and V0 candidates, it loops over V0 daughters and compares the track with both daughters.

@jgrosseo
Copy link
Contributor

Thanks @lauraser
I only have few comments, see above. @mario-krueger will comment on the histogram registry lines and this is only a minor change, too. After that we can merge.

mHistogramRegistryQA = registryQA;

if constexpr (mPartOneType == o2::aod::femtodreamparticle::ParticleType::kTrack && mPartTwoType == o2::aod::femtodreamparticle::ParticleType::kTrack) {
histdetadpi[0][0] = std::get<std::shared_ptr<TH2>>(mHistogramRegistry->add((static_cast<std::string>(histNames[0][0])).c_str(), "; #Delta #eta; #Delta #phi", kTH2F, {{100, -2.5, 2.5}, {100, -2.5, 2.5}}));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi Laura,
we now have an add() function in the HistogramRegistry that directly returns the histogram pointer (no more need to extract it manually from the HistType variant via std::get):

histdetadpi[0][0] = mHistogramRegistry->add<TH2>(...)

(see for instance here: https://github.com/AliceO2Group/O2Physics/blob/master/PWGLF/Tasks/spectraTPC.cxx#L71)
Cheers,
Mario

@jgrosseo jgrosseo enabled auto-merge (squash) October 11, 2021 13:56
@jgrosseo jgrosseo merged commit 8be1e75 into AliceO2Group:master Oct 11, 2021
ddobrigk added a commit that referenced this pull request Sep 14, 2023
* Add extra QA vars

* Please consider the following formatting changes (#168)

---------

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 6, 2023
* Add extra QA vars

* Please consider the following formatting changes (AliceO2Group#168)

---------

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
hahassan7 pushed a commit to hahassan7/O2Physics that referenced this pull request Oct 7, 2023
* Add extra QA vars

* Please consider the following formatting changes (AliceO2Group#168)

---------

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
samrangy pushed a commit to samrangy/O2Physics that referenced this pull request Oct 11, 2023
* Add extra QA vars

* Please consider the following formatting changes (AliceO2Group#168)

---------

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
zconesa pushed a commit to zconesa/O2Physics that referenced this pull request Oct 27, 2023
* Add extra QA vars

* Please consider the following formatting changes (AliceO2Group#168)

---------

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
chengtt0406 pushed a commit to chengtt0406/O2Physics that referenced this pull request Dec 6, 2023
* Add extra QA vars

* Please consider the following formatting changes (AliceO2Group#168)

---------

Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants