-
Notifications
You must be signed in to change notification settings - Fork 628
Close Pair Rejection for Femto #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi Laura. |
|
Dear Jan, the main differences are that:
We cannot confirm that this will be as well our final solution for Run3 as we have to test if the same approach works on real data. However, we must validate our codes by comparing AliPhysics results with our new implementation in O2, and thus we need exact replica of the tasks we currently have in AliPhysics. |
|
Our implementation as well deals separately with different candidates. For example, if the function is called for track and V0 candidates, it loops over V0 daughters and compares the track with both daughters. |
|
Thanks @lauraser |
| mHistogramRegistryQA = registryQA; | ||
|
|
||
| if constexpr (mPartOneType == o2::aod::femtodreamparticle::ParticleType::kTrack && mPartTwoType == o2::aod::femtodreamparticle::ParticleType::kTrack) { | ||
| histdetadpi[0][0] = std::get<std::shared_ptr<TH2>>(mHistogramRegistry->add((static_cast<std::string>(histNames[0][0])).c_str(), "; #Delta #eta; #Delta #phi", kTH2F, {{100, -2.5, 2.5}, {100, -2.5, 2.5}})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi Laura,
we now have an add() function in the HistogramRegistry that directly returns the histogram pointer (no more need to extract it manually from the HistType variant via std::get):
histdetadpi[0][0] = mHistogramRegistry->add<TH2>(...)(see for instance here: https://github.com/AliceO2Group/O2Physics/blob/master/PWGLF/Tasks/spectraTPC.cxx#L71)
Cheers,
Mario
* Add extra QA vars * Please consider the following formatting changes (#168) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
* Add extra QA vars * Please consider the following formatting changes (AliceO2Group#168) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
* Add extra QA vars * Please consider the following formatting changes (AliceO2Group#168) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
* Add extra QA vars * Please consider the following formatting changes (AliceO2Group#168) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
* Add extra QA vars * Please consider the following formatting changes (AliceO2Group#168) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
* Add extra QA vars * Please consider the following formatting changes (AliceO2Group#168) --------- Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch> Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
The class is performing the close pair rejection check for particle pairs.