[PWGLF] Added TOF condition

[JimunLee]

Dear experts,

I just fixed the conditions of TOF.

Thank you
Jimun Lee

[github-actions]

O2 linter results: ❌ 20 errors, ⚠️ 0 warnings, 🔕 0 disabled

[JimunLee]

Dear experts,

I have worked hard to fix the O2 linter issues, and I think I have changed almost everything except for a few minor ones.
If you find any remaining issues that i should correct, I would appreciate your feedback!

Thank you
Best regards,
Jimun

[dmallick2]

@JimunLee thanks , still you have a few errors related to " Use lowerCamelCase for names of functions and variables". Could you please fix this

[JimunLee]

@JimunLee thanks , still you have a few errors related to " Use lowerCamelCase for names of functions and variables". Could you please fix this

@dmallick2 thank you for giving your feedback, and I have fixed a few errors regarding "Use lowerCamelCase for names of functions and variables". But related to some remaining cases, I prefer to use the expression instead of following o2 linter comments because of easily understanding the meaning of them for me.

So, I would like to keep them!

Thank you!
Best regards,
Jimun

[vkucera]

Hi @JimunLee , thanks for the effort to fix the errors.
You still have the following errors: include-iostream, root/lorentz-vector, logging, magic-number. Please fix them too.
Concerning the naming conventions, can you please give an example of a name that would the conventions make harder for you to understand?

[JimunLee]

Hi @vkucera, Thank you for comments!

I was under the impression that the O2linter comments were fully optional to implement?
I like to use the TLortenzVector, as I am more used to it, and currently my code does not cause memory/cpu issues.

However, I will try to make some changes for my next PR!

Best Regards,
Jimun

[vkucera]

Hi @JimunLee , passing the O2 linter test is not required to merge a PR because we want to avoid blocking PRs by issues introduced by a third person earlier.
O2 linter does not just report bugs, but also issues that affect things like compiler optimisation, performance, code safety, readability, and maintainability.
We are all contributing to a common collaboration code and share common collaboration resources. This is why all these aspects are essential for a productive teamwork.
As I said in the documentation:

fixing issues improves the code for everybody.

If the rationale of some errors is not clear to you, please check the summary table and links in the linter output.