[Common] Event selection flags added #12418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximVirta
requested review from
a team,
alibuild,
ddobrigk,
iarsene,
jgrosseo and
ktf
as code owners
|
O2 linter results: ❌ 37 errors, |
Please consider the following formatting changes to AliceO2Group#12418
vkucera
reviewed
Aug 4, 2025
Comment on lines
+546
to
+551
| switch (cfgEvtSel) { | ||
| case 0: // Sel8 | ||
| if (!qVec.sel8()) | ||
| return; | ||
| break; | ||
| case 1: // PbPb standard |
Collaborator
There was a problem hiding this comment.
Do not use magic numbers. Define an enumerator for the supported cases.
ddobrigk
approved these changes
Aug 6, 2025
Collaborator
|
Approved - please consider Vit's comment for a next PR at a quieter time |
jpxrk
pushed a commit
to jpxrk/O2Physics
that referenced
this pull request
Aug 12, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Dec 5, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event selection flags to distinguish selections between PbPb and smaller systems (OO, Ne-Ne)