Skip to content

[PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction #11489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgrosa merged 11 commits into from
Jun 10, 2025
Merged

[PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction #11489

fgrosa merged 11 commits into from
Jun 10, 2025

Conversation

@lubynets
Copy link
Contributor

@lubynets lubynets commented Jun 6, 2025

  1. Kalman Filter specific variables are added to the list of available features for ML selection of Lc->PKPi decays.
  2. ML scores are propagated to the output of the treeCreatorLcToPKPi workflow.

@github-actions github-actions bot added the pwghf PWG-HF label Jun 6, 2025
@github-actions
Copy link

github-actions bot commented Jun 6, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Enable ML selection in KF-based LcToPKPi reconstruction [PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction Jun 6, 2025
vkucera
vkucera reviewed Jun 6, 2025
View reviewed changes
vkucera
vkucera requested changes Jun 6, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the error

@lubynets
Copy link
Contributor Author

lubynets commented Jun 6, 2025 •
edited by vkucera
Loading

Please fix the error

The error message says that massLc here https://github.com/lubynets/O2Physics/blob/f296218aedf244f6a6df0184e799bc46373c08fd/PWGHF/TableProducer/candidateSelectorLc.cxx#L310 is uninitialized. Do I understand correctly that it is supposed to be initialized explicitly when declared here https://github.com/lubynets/O2Physics/blob/f296218aedf244f6a6df0184e799bc46373c08fd/PWGHF/TableProducer/candidateSelectorLc.cxx#L290 like float massLc{0.f} (although it is assigned with a meaningful value later)?

Yes. It is not guaranteed that any value is assigned.

@fgrosa fgrosa merged commit 6368dce into AliceO2Group:master Jun 10, 2025
13 checks passed
@lubynets lubynets deleted the KfMl branch June 10, 2025 11:40
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@lubynets @jinhyunni
[PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction (Alic…
1086ee6 
…eO2Group#11489)
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
@lubynets
[PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction (Alic…
fdc08f1 
…eO2Group#11489)
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@lubynets
[PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction (Alic…
301e5a3 
…eO2Group#11489)
lietava pushed a commit to lietava/O2Physics that referenced this pull request Jun 14, 2025
@lubynets @lietava
[PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction (Alic…
d416e0f 
…eO2Group#11489)
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@lubynets
[PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction (Alic…
3757bda 
…eO2Group#11489)
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@lubynets @CesarOmarRA
[PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction (Alic…
4699d4a 
…eO2Group#11489)
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@lubynets @jloemker
[PWGHF] Enable ML selection in KF-based LcToPKPi reconstruction (Alic…
30751e1 
…eO2Group#11489)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lubynets @vkucera @fgrosa