Skip to content

[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons #11384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkucera merged 21 commits into from
Jun 6, 2025
Merged

[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons #11384

vkucera merged 21 commits into from
Jun 6, 2025

Conversation

@singhra1994
Copy link
Collaborator

@singhra1994 singhra1994 commented May 27, 2025 •
edited
Loading

once this task will fully implemented and verified, correlatorLcHadrons.cxx will be replaced with correlatorLcScHadrons.cxx, It will be important to compare Lc-hadron results with the old task

@github-actions github-actions bot added the pwghf PWG-HF label May 27, 2025
@github-actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title PWGHF: created a duplicate task to correlate Lc and Sc with hadrons [PWGHF] created a duplicate task to correlate Lc and Sc with hadrons May 27, 2025
@alibuild alibuild mentioned this pull request May 27, 2025
Merged
@singhra1994
Merge pull request #28 from alibuild/alibot-cleanup-11384
792ff03 
[PWGHF] Please consider the following formatting changes to AliceO2Group#11384
@alibuild
Copy link
Collaborator

alibuild commented May 27, 2025

Error while checking build/O2Physics/o2 for 792ff03 at 2025-05-27 22:55:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/11384-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorLcScHadrons.cxx:174:17: error: 'CandChargePair' is not a member of 'o2::aod'
/sw/SOURCES/O2Physics/11384-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorLcScHadrons.cxx:174:31: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/11384-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorLcScHadrons.cxx:175:17: error: 'CandCharge' is not a member of 'o2::aod'
/sw/SOURCES/O2Physics/11384-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorLcScHadrons.cxx:175:27: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/11384-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorLcScHadrons.cxx:432:24: error: expression cannot be used as a function
/sw/SOURCES/O2Physics/11384-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorLcScHadrons.cxx:624:26: error: expression cannot be used as a function
/sw/SOURCES/O2Physics/11384-slc9_x86-64/0/PWGHF/HFC/TableProducer/correlatorLcScHadrons.cxx:643:26: error: expression cannot be used as a function
ninja: build stopped: subcommand failed.

Full log here.

@apalasciano
Copy link
Collaborator

apalasciano commented May 28, 2025

Hello Ravindra,
Thank you for the additions.
Since the recent commits included a direct rename of the correlatorLcHadrons.cxx class, we unfortunately lose the commit history associated with that file. You can check it if you open the new file and look for its history.
To preserve backward compatibility and maintain the file’s development history, I would recommend changing approach.
In your repository, please run:
git mv correlatorLcHadrons.cxx correlatorLcScHadrons.cxx
Then, apply your modifications to the newly renamed file.
This way, the history of correlatorLcHadrons.cxx is preserved, even after renaming.
Thanks again!

@vkucera
Copy link
Collaborator

vkucera commented May 28, 2025 •
edited
Loading

Hi @singhra1994 @apalasci , my understanding was that correlatorLcScHadrons.cxx was created by copying correlatorLcHadrons.cxx without the intention to delete correlatorLcHadrons.cxx but it is not clear to me what the development plan is.

@singhra1994
Copy link
Collaborator Author

singhra1994 commented May 29, 2025

Hi @singhra1994 @apalasci , my understanding was that correlatorLcScHadrons.cxx was created by copying correlatorLcHadrons.cxx without the intention to delete correlatorLcHadrons.cxx but it is not clear to me what the development plan is.

HI @vkucera, my plan is to check and compare the results of new task correlatorLcScHadrons.cxx with old correlatorLcHadrons.cxx for Lambda_c. Once it validated we can replace it with old as @apalasciano mentioned. Structurally new task is different, modular and has very less duplication. I cannot verify it locally due to less stats

vkucera
vkucera reviewed May 30, 2025
View reviewed changes
@alibuild alibuild mentioned this pull request Jun 1, 2025
Merged
@singhra1994 singhra1994 marked this pull request as ready for review June 3, 2025 09:47
vkucera
vkucera requested changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions on the code.
Please be more careful about the arguments in function signatures, especially the correct use of const.

@singhra1994 singhra1994 requested a review from gluparel as a code owner June 3, 2025 14:02
@alibuild alibuild mentioned this pull request Jun 3, 2025
Merged
@alibuild alibuild mentioned this pull request Jun 4, 2025
Merged
@singhra1994
Merge pull request #31 from alibuild/alibot-cleanup-11384
5e5f9b8 
Please consider the following formatting changes to AliceO2Group#11384
vkucera
vkucera reviewed Jun 4, 2025
View reviewed changes
vkucera
vkucera approved these changes Jun 6, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @singhra1994 , it looks good to me.

@vkucera vkucera merged commit 518416c into AliceO2Group:master Jun 6, 2025
13 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@singhra1994 @alibuild @jinhyunni
[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons (A…
2a82616 
…liceO2Group#11384)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Jun 11, 2025
@singhra1994 @alibuild
[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons (A…
72354e9 
…liceO2Group#11384)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Jun 12, 2025
@singhra1994 @alibuild @EmilGorm
[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons (A…
19d5b48 
…liceO2Group#11384)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@singhra1994 @alibuild
[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons (A…
b333ff1 
…liceO2Group#11384)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@singhra1994 @alibuild
[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons (A…
c400041 
…liceO2Group#11384)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@singhra1994 @alibuild @smaff92
[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons (A…
dd41d29 
…liceO2Group#11384)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jul 16, 2025
@singhra1994 @alibuild @romainschotter
[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons (A…
1bb40dd 
…liceO2Group#11384)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@singhra1994 @alibuild @CesarOmarRA
[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons (A…
7b385a1 
…liceO2Group#11384)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@singhra1994 @alibuild @jloemker
[PWGHF] created a duplicate task to correlate Lc and Sc with hadrons (A…
142c72e 
…liceO2Group#11384)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@singhra1994 @alibuild @apalasciano @vkucera