[PWGJE] separation of process functions for MCD and Data tables for Tracks and Multiplicities + Refactoring of the task

[Archita-Dash]

No description provided.

[github-actions]

O2 linter results: ❌ 6 errors, ⚠️ 0 warnings, 🔕 0 disabled

[alibuild]

Error while checking build/O2Physics/o2 for f66cd59 at 2025-05-13 18:43:

## sw/BUILD/arrow-latest/log
/sw/BUILD/5c423fbe2eb3b52187e935043b0d4602548f9a00/arrow/src_tmp/cpp/src/gandiva/precompiled/arithmetic_ops.cc:18:10: fatal error: 'cmath' file not found
/sw/BUILD/5c423fbe2eb3b52187e935043b0d4602548f9a00/arrow/src_tmp/cpp/src/arrow/util/basic_decimal.h:20:10: fatal error: 'array' file not found
ninja: build stopped: subcommand failed.

Full log here.

[alibuild]

Error while checking build/O2Physics/o2 for ff2adc3 at 2025-05-13 22:14:

## sw/BUILD/arrow-latest/log
/sw/BUILD/5c423fbe2eb3b52187e935043b0d4602548f9a00/arrow/src_tmp/cpp/src/gandiva/precompiled/arithmetic_ops.cc:18:10: fatal error: 'cmath' file not found
ninja: build stopped: subcommand failed.

Full log here.

[Archita-Dash]

Hi @nzardosh ,
somehow the check for 'build/O2Physics/o2` has failed. From the log there seems to be a missing 'cmath.h' file but it is unclear to me if I should include this header file in my task(?). I am not sure how to fix this error as this does not pop up in local build and this error is showing up for the first time.
Thank you.

[mhemmer-cern]

Hi @nzardosh , somehow the check for 'build/O2Physics/o2` has failed. From the log there seems to be a missing 'cmath.h' file but it is unclear to me if I should include this header file in my task(?). I am not sure how to fix this error as this does not pop up in local build and this error is showing up for the first time. Thank you.

Hey @Archita-Dash ,
This is a general problem and not related to your PR. Giulio mentioned it yesterday in the O2 Analysis channel. So they are investigating and hopefully fixing this soon.

[Archita-Dash]

Hi @nzardosh , somehow the check for 'build/O2Physics/o2` has failed. From the log there seems to be a missing 'cmath.h' file but it is unclear to me if I should include this header file in my task(?). I am not sure how to fix this error as this does not pop up in local build and this error is showing up for the first time. Thank you.

Hey @Archita-Dash , This is a general problem and not related to your PR. Giulio mentioned it yesterday in the O2 Analysis channel. So they are investigating and hopefully fixing this soon.

Hi @mhemmer-cern ,
thanks a lot for the clarification.

[vkucera]

The linter errors are unrelated to the build failure, so why not fixing them? :-)

[mhemmer-cern]

@nzardosh can this be squashed and merged?

[vkucera]

@nzardosh can this be squashed and merged?

There are actual bugs reported by the linters. This should not have been even approved.

[mhemmer-cern]

@nzardosh can this be squashed and merged?

There are actual bugs reported by the linters. This should not have been even approved.

Ah I overlooked the MegaLinter. Yeah that should be fixed first.

[nzardosh]

It seems there are quite a few if statements that dont do anything. Could you check and correct these please? Otherwise looks good to me

[nzardosh]

@mhemmer-cern let me know when this is ready

[vkucera]

@nzardosh I don't see any changes. Why is it approved now?

[mhemmer-cern]

@nzardosh Archita will push some changes fixing the MegaLinter error soon I think.

[nzardosh]

It was approved by mistake, thats why i didnt merge and commented straight after asking to let me know when there are updates

[vkucera]

OK. Thanks. From your reply, I would say that the PP is there by coincidence and not by intention and nothing prevents the extension to other collision systems. If the PP is removed later, it would change the name of the workflow and of the device which are bound to the wagon configuration on AliHyperloop. One would have to configure the wagon from scratch which might not be convenient. So I would recommend to remove the PP now.

[Archita-Dash]

OK. Thanks. From your reply, I would say that the PP is there by coincidence and not by intention and nothing prevents the extension to other collision systems. If the PP is removed later, it would change the name of the workflow and of the device which are bound to the wagon configuration on AliHyperloop. One would have to configure the wagon from scratch which might not be convenient. So I would recommend to remove the PP now.

Okay, I can certainly create a new PR after this current PR is merged, to modify the task name.

[vkucera]

Well, the current version of this PR is failing with the name/o2-task error so you will have to touch the name anyway.
Why would you prefer to do it later?

[Archita-Dash]

Hi @nzardosh , I pushed the fixes now. I see that the O2linter issues are arising from the CMakeList file where the only change I made is renaming my taskname. Is there something else I should change? The errors are related to some other tasknames which are exactly the same as on the master branch.

[Archita-Dash]

Well, the current version of this PR is failing with the name/o2-task error so you will have to touch the name anyway. Why would you prefer to do it later?

This error has now been fixed and pushed. Can now my PR status be changed to "Ready for Review" please?

[vkucera]

Well, the current version of this PR is failing with the name/o2-task error so you will have to touch the name anyway. Why would you prefer to do it later?

This error has now been fixed and pushed. Can now my PR status be changed to "Ready for Review" please?

Thanks @Archita-Dash

[mhemmer-cern]

Hello @nzardosh or @maoyx could you please check this PR again now with everything fix?