[PWGCF] Identified BF Added purity histograms for genereated particles, added track time histograms

[bghanley1995]

No description provided.

[bghanley1995]

I have fixed the code that is giving the "Magic Number" O2 Linter error, and when I run O2 Linter locally it doesn't find any issues, but here it does.

[vkucera]

I have fixed the code that is giving the "Magic Number" O2 Linter error, and when I run O2 Linter locally it doesn't find any issues, but here it does.

Because your branch is outdated.

[vkucera]

This is does not help to understand what is the meaning of the value.

[bghanley1995]

I am doing a check using remainder in integer division of the particle ID value by 2. Even ID values are positive charged particles and odd ID values are negative charged particles. The error was specifically that I was doing the division by the integer 2 instead of a variable. I am unsure what I should name this variable to make it more descriptive as it is just the number 2 used for this check. Is there a standard naming convention for this situation?

[victor-gonzalez]

I guess the point @vkucera wanted to make is, there is the same magic in using 0 than in using trackType[0]
Both have the same opacity when reading the code and are prone to errors, difficult to maintain and hard to evolve

What about, for example,

constexpr int kEvenOddBase = 2;
constexpr int kPositiveTrackId = 0;
constexpr int kNegativeTrackId = 1;

and then

          if (pid % kEvenOddBase == kPositiveTrackId) {
          .......
          }

Have in mind that if the constexpr variables are defined in the scope of a struct they have to be declared as static

[victor-gonzalez]

Have a look at my comment for the future iterations