[PWGCF] Identified Bf, Changed how PID is performed, added configurables to improve performance #10714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghanley1995
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
github-actions
bot
changed the title
bghanley1995
added a commit
to bghanley1995/O2Physics
that referenced
this pull request
Apr 1, 2025
[PWGCF] Please consider the following formatting changes to AliceO2Group#10714
Collaborator
|
Error while checking build/O2Physics/o2 for cdb950b at 2025-04-01 10:16: Full log here. |
[PWGCF] Please consider the following formatting changes to AliceO2Group#10714
Comment on lines
+1035
to
+1046
| for (int sp1 = 0; sp1 < kIdBfNoOfSpecies; ++sp1) { | ||
| for (int sp2 = 0; sp2 < kIdBfNoOfSpecies; ++sp2) { | ||
| fhTrueNSigmaTPC[sp1][sp2] = new TH2F(TString::Format("fhTrueNSigmaTPC%s_%s", speciesName[sp1], speciesName[sp2]).Data(), | ||
| TString::Format("N #sigma %s from TPC vs P for generated %s;N #sigma;p (GeV/c)", speciesTitle[sp1], speciesTitle[sp2]).Data(), | ||
| 48, -6, 6, | ||
| ptbins, ptlow, ptup); | ||
|
|
||
| fhTrueNSigmaTOF[sp1][sp2] = new TH2F(TString::Format("fhTrueNSigmaTOF%s_%s", speciesName[sp1], speciesName[sp2]).Data(), | ||
| TString::Format("N #sigma %s from TOF vs P for generated %s;N #sigma;p (GeV/c)", speciesTitle[sp1], speciesTitle[sp2]).Data(), | ||
| 48, -6, 6, | ||
| ptbins, ptlow, ptup); | ||
| } |
Collaborator
There was a problem hiding this comment.
Why two species indexes?
Contributor
Author
There was a problem hiding this comment.
I wanted to examine how the smearing effect on the N sigma values of TPC cause contamination when I run PID. When I fill these histograms, the first species index is species that I am measuring N Sigma for, the other is the generated species as determined by PDG value. I also use the plot corresponding to the generated particle species (eg, N Sigma pion for generated pions) to get my corrections for the smearing.
victor-gonzalez
approved these changes
Apr 1, 2025
louisemillot
pushed a commit
to louisemillot/O2Physics
that referenced
this pull request
Apr 8, 2025
…les to improve performance (AliceO2Group#10714) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
njacazio
pushed a commit
that referenced
this pull request
Apr 11, 2025
…les to improve performance (#10714) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
EmilGorm
pushed a commit
to EmilGorm/O2Physics
that referenced
this pull request
Apr 15, 2025
…les to improve performance (AliceO2Group#10714) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
…les to improve performance (AliceO2Group#10714) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
…les to improve performance (AliceO2Group#10714) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
…les to improve performance (AliceO2Group#10714) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.