[PWGCF] IdentifiedBfFilter Moved N Sigma Plots #10650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to show PID contamination
bghanley1995
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
github-actions
bot
changed the title
[PWGCF] Please consider the following formatting changes to AliceO2Group#10650
[PWGCF] Please consider the following formatting changes to AliceO2Group#10650
vkucera
reviewed
Mar 26, 2025
| MatchRecoGenSpecies realPID = kWrongSpecies; | ||
| int pdgcode = std::fabs(particle.pdgCode()); | ||
| switch (pdgcode) { | ||
| case pdgcodeEl: |
Collaborator
There was a problem hiding this comment.
Suggested change
| case pdgcodeEl: | |
| case kElectron: |
These should be fixed.
Collaborator
There was a problem hiding this comment.
@bghanley1995, @vkucera is right!
You don't need to redefine
constexpr int pdgcodeEl = 11;
constexpr int pdgcodePi = 211;
constexpr int pdgcodeKa = 321;
constexpr int pdgcodePr = 2212;
what is already defined in TPDGCode.h
Please, address this in the next iteration
victor-gonzalez
approved these changes
Mar 26, 2025
louisemillot
pushed a commit
to louisemillot/O2Physics
that referenced
this pull request
Apr 8, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
njacazio
pushed a commit
that referenced
this pull request
Apr 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
EmilGorm
pushed a commit
to EmilGorm/O2Physics
that referenced
this pull request
Apr 15, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.