[PWGCF] identifiedbf.cxx Added histograms for purity testing #10557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghanley1995
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
bghanley1995
added a commit
to bghanley1995/O2Physics
that referenced
this pull request
Mar 18, 2025
[PWGCF] Please consider the following formatting changes to AliceO2Group#10557
[PWGCF] Please consider the following formatting changes to AliceO2Group#10557
| } else { | ||
| return phi; | ||
| } | ||
| phi = RecoDecay::constrainAngle(phi, philow, phiup); |
Collaborator
There was a problem hiding this comment.
Be sure that you use constrainAngle in the way it is intended (third parameter is the harmonic)
Check locally that you are getting the results you expect
Contributor
Author
There was a problem hiding this comment.
Thank you, Victor! I will fix this and check!
| WorkflowSpec defineDataProcessing(ConfigContext const& cfgc) | ||
| { | ||
| WorkflowSpec workflow{ | ||
| adaptAnalysisTask<IdentifiedBfCorrelationsTask>(cfgc, TaskName{"IdentifiedBfCorrelationsTaskRec"}, SetDefaultProcesses{{{"processRecLevel", true}, {"processRecLevelMixed", false}, {"processCleaner", false}}}), |
Collaborator
There was a problem hiding this comment.
You cannot comply with this linter requirement because, as the message says, the task is adapted multiple times
For these cases there is a recommended way of silencing linter complaints, use // o2-linter: disable=name/o2-task as a comment at the end of each line which adapts the task
Contributor
Author
There was a problem hiding this comment.
Thank you! I'll make sure to run the linter and silence these requirements before pushing my next commit.
…ct in identifiedbf.cxx to meet O2Linter requirements
victor-gonzalez
approved these changes
Mar 18, 2025
lubynets
pushed a commit
to lubynets/O2Physics
that referenced
this pull request
Mar 22, 2025
…Group#10557) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
louisemillot
pushed a commit
to louisemillot/O2Physics
that referenced
this pull request
Apr 8, 2025
…Group#10557) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
njacazio
pushed a commit
that referenced
this pull request
Apr 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
EmilGorm
pushed a commit
to EmilGorm/O2Physics
that referenced
this pull request
Apr 15, 2025
…Group#10557) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern
pushed a commit
to ariedel-cern/O2Physics
that referenced
this pull request
May 23, 2025
…Group#10557) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92
pushed a commit
to smaff92/O2Physics
that referenced
this pull request
Jun 17, 2025
…Group#10557) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
…Group#10557) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.