Skip to content

[PWGCF] Significant update where event mixing is changed as well as changed f…#10251

Merged
victor-gonzalez merged 13 commits intoAliceO2Group:masterfrom
Thorkj:master
Mar 5, 2025
Merged

[PWGCF] Significant update where event mixing is changed as well as changed f…#10251
victor-gonzalez merged 13 commits intoAliceO2Group:masterfrom
Thorkj:master

Conversation

@Thorkj
Copy link
Contributor

@Thorkj Thorkj commented Feb 28, 2025

…rom sparses to correlation container

@github-actions github-actions bot added the pwgcf label Feb 28, 2025
@github-actions github-actions bot changed the title Significant update where event mixing is changed as well as changed f… [PWGCF] Significant update where event mixing is changed as well as changed f… Feb 28, 2025
@alibuild alibuild mentioned this pull request Feb 28, 2025
Closed
@alibuild alibuild mentioned this pull request Feb 28, 2025
Closed
@Thorkj Thorkj marked this pull request as ready for review February 28, 2025 15:35
@Thorkj
Copy link
Contributor Author

Thorkj commented Feb 28, 2025

I can spend more time trying to fix the linter issue, but I feel like the name of the column and the getter feels appropriate for what it does.

@alibuild
Copy link
Collaborator

alibuild commented Feb 28, 2025

Error while checking build/O2Physics/o2 for af945df at 2025-02-28 17:10:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:69:47: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

victor-gonzalez
victor-gonzalez reviewed Feb 28, 2025
View reviewed changes
PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx Outdated

namespace o2::aod
{
namespace multiplicity_nch
Copy link
Collaborator

@victor-gonzalez victor-gonzalez Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a name more adapted to your analysis to avoid clashes
What about corrsparse?

victor-gonzalez
victor-gonzalez reviewed Feb 28, 2025
View reviewed changes
PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx Outdated
{
namespace multiplicity_nch
{
DECLARE_SOA_COLUMN(Multiplicity, mulT, int);
Copy link
Collaborator

@victor-gonzalez victor-gonzalez Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use

DECLARE_SOA_COLUMN(Multiplicity, multiplicity, int);

as recommended by linter

victor-gonzalez
victor-gonzalez reviewed Feb 28, 2025
View reviewed changes
PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx Outdated
void processSame(AodCollisions::iterator const& collision, AodTracks const& tracks)
{

// LOGF(info, "Process Same | Nch: %i | Mult from column %i", tracks.size(), collision.mulT());
Copy link
Collaborator

@victor-gonzalez victor-gonzalez Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't leave code commented

victor-gonzalez
victor-gonzalez reviewed Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, have a look at my comments

@victor-gonzalez
Copy link
Collaborator

victor-gonzalez commented Feb 28, 2025

I can spend more time trying to fix the linter issue, but I feel like the name of the column and the getter feels appropriate for what it does.

Not quite sure I understand what you mean by trying, there are not too many ways of following linter recommendations

@alibuild alibuild mentioned this pull request Mar 4, 2025
Merged
@Thorkj
Merge pull request #9 from alibuild/alibot-cleanup-10251
a2b9aed 
[PWGCF] Please consider the following formatting changes to AliceO2Group#10251
@alibuild
Copy link
Collaborator

alibuild commented Mar 4, 2025

Error while checking build/O2Physics/o2 for a2b9aed at 2025-03-04 10:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:69:47: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Mar 4, 2025

Error while checking build/O2Physics/o2 for 526592e at 2025-03-04 11:16:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:69:47: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Mar 4, 2025

Error while checking build/O2Physics/o2 for da502d8 at 2025-03-04 21:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:155:134: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:155:50: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:155:242: error: expected ')' before ';' token
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:155:242: error: expected ')' before ';' token
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:156:136: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:156:51: error: too many arguments for format [-Werror=format-extra-args]
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:156:245: error: expected ')' before ';' token
/sw/SOURCES/O2Physics/10251-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/corrSparse.cxx:156:245: error: expected ')' before ';' token
ninja: build stopped: subcommand failed.

Full log here.

@victor-gonzalez victor-gonzalez merged commit 9e32de0 into AliceO2Group:master Mar 5, 2025
13 checks passed
njacazio pushed a commit that referenced this pull request Apr 11, 2025
@Thorkj @alibuild @njacazio
[PWGCF] Significant update where event mixing is changed as well as c…
7285bf6 
…hanged f… (#10251)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
EmilGorm pushed a commit to EmilGorm/O2Physics that referenced this pull request Apr 15, 2025
@Thorkj @alibuild @EmilGorm
[PWGCF] Significant update where event mixing is changed as well as c…
d1fc190 
…hanged f… (AliceO2Group#10251)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@Thorkj @alibuild @ariedel-cern
[PWGCF] Significant update where event mixing is changed as well as c…
94b8a17 
…hanged f… (AliceO2Group#10251)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild added a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@Thorkj @alibuild @CesarOmarRA
[PWGCF] Significant update where event mixing is changed as well as c…
09a18bd 
…hanged f… (AliceO2Group#10251)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@saganatt saganatt Awaiting requested review from saganatt

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thorkj @alibuild @victor-gonzalez