MathUtils: move BetheBlochAleph to a common header#14918
MathUtils: move BetheBlochAleph to a common header#14918ktf merged 2 commits intoAliceO2Group:devfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
The codechecker on ARM seems to complain about more stuff than on X86. |
|
Some of the checks depend on how the code is actually optimised, so that's architecture specific. PR updated with the fix. |
|
@wiechula @davidrohr could you sign off this as TPC? Why was this not part of the common utils? |
|
(or @shahor02, of course) |
davidrohr
left a comment
There was a problem hiding this comment.
In general, I am fiine with this, but why do you keep the BetheBlochAleph.h header with just forwarding the function? I would say we should remove the header completely.
|
To avoid breaking O2Physics. We can clean it up once merged. |
|
Is the error in dataflow: a known issue? |
Yes, I wrote on Mattermost to Sergio and you. It seems the dataflow container was changed, which enabled some GPU tests developed by Matteo. These tests never ran before, since the FullCI has ctests disabled to speed up the build. It seems these tests are generally broken, I tried locally on my system and they are failing as well. #14935 disables them. Not merged yet since I discovered some more tests are failing and I want to get it fully clean. We can merge the BetheBlockAleph PR if you like. |
No description provided.