HybridGen/EventPool: small fixes, Add missing EventHeader propagation#13801
Merged
sawenzel merged 1 commit intoAliceO2Group:devfrom Dec 16, 2024
Merged
HybridGen/EventPool: small fixes, Add missing EventHeader propagation#13801sawenzel merged 1 commit intoAliceO2Group:devfrom
sawenzel merged 1 commit intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Collaborator
|
Error while checking build/O2/fullCI for 8222c00 at 2024-12-14 13:19: Full log here. |
8222c00 to
769dfb3
Compare
f88d85b to
e6a57a6
Compare
The HybridGen needs to forward event headers from the underlying generators. In order to access these, we need to make a protected function public. Also adding eventHeader treatment to BoxGenerator. More fixes: - clear particle container in EventPool - do not modify particle statuses in HybridGen (lead to wrong Geant4 simulations) - fix possible segfault in chosing EventPool file
e6a57a6 to
33f829c
Compare
jackal1-66
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HybridGen needs to forward event headers from the underlying
generators.
In order to access these, we need to make a protected function public.
Also adding eventHeader treatment to BoxGenerator.
More fixes: