Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions Sprint-2/implement_skip_list/skip_list.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
import random


class SkipListNode:
"""Node in a skip list with multiple forward pointers"""
def __init__(self, value, levels):
self.value = value
self.forward = [None] * levels


class SkipList:
def __init__(self):
self.max_level = 16
self.head = SkipListNode(float('-inf'), self.max_level)
self.level = 0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line reassigns current to current.forward[0], but the variable is never read again — making it dead code. It looks like a leftover from a duplicate-check pattern. Since the assignment doesn't require uniqueness you can safely remove this line, or if you do want to guard against duplicates you could add:

Suggested change
current = current.forward[0]
if current is not None and current.value == value:
return # value already exists, skip duplicate

Either way, leaving an unused variable assignment makes the code harder to read and may mislead future readers into thinking the value is checked.

def _random_level(self):
"""Generate random level for a new node (coin flip)"""
level = 0
while random.random() < 0.5 and level < self.max_level - 1:
level += 1
return level

def insert(self, value):
"""Insert value in sorted order - O(log n) time complexity"""
update = [None] * self.max_level
current = self.head

for i in range(self.level, -1, -1):
while current.forward[i] and current.forward[i].value < value:
current = current.forward[i]
update[i] = current

current = current.forward[0]
new_level = self._random_level()

if new_level > self.level:
for i in range(self.level + 1, new_level + 1):
update[i] = self.head
self.level = new_level

new_node = SkipListNode(value, new_level + 1)

for i in range(new_level + 1):
new_node.forward[i] = update[i].forward[i]
update[i].forward[i] = new_node

def contains(self, value) -> bool:
"""Check if value exists - O(log n) time complexity"""
current = self.head

for i in range(self.level, -1, -1):
while current.forward[i] and current.forward[i].value < value:
current = current.forward[i]

current = current.forward[0]
return current is not None and current.value == value

def to_list(self) -> list:
"""Convert to sorted list - O(n) time complexity"""
result = []
current = self.head.forward[0]
while current:
result.append(current.value)
current = current.forward[0]
return result

def __contains__(self, value) -> bool:
return self.contains(value)
Loading