Skip to content

Implement LUR cache using OrderedDict dictionary#2

Closed
AliQassab wants to merge 1 commit intomainfrom
Implement-an-LRU-cache-in-Python
Closed

Implement LUR cache using OrderedDict dictionary#2
AliQassab wants to merge 1 commit intomainfrom
Implement-an-LRU-cache-in-Python

Conversation

@AliQassab
Copy link
Copy Markdown
Owner

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@AliQassab AliQassab added the needreview PR is pending AI review label Mar 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab AliQassab closed this Mar 8, 2026
@AliQassab AliQassab reopened this Mar 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab AliQassab closed this Mar 8, 2026
@AliQassab AliQassab reopened this Mar 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab AliQassab closed this Mar 8, 2026
@AliQassab AliQassab reopened this Mar 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab AliQassab closed this Mar 8, 2026
@AliQassab AliQassab reopened this Mar 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab
Copy link
Copy Markdown
Owner Author

Summary

This PR aims to implement a Least Recently Used (LRU) cache using Python's OrderedDict from the collections module. However, it appears that no files have been changed or committed in this pull request, which means there is no code to review at this time.

Positive Feedback

  • The intention to use OrderedDict for implementing an LRU cache is a good choice as it maintains the order of insertion, which is useful for cache eviction policies.

Issues Found

  • No files have been changed in this PR, so there is no code to review.
  • The PR title does not follow the required format: "Region | Cohort | FirstName LastName | Sprint | Assignment Title".
  • The self-checklist in the PR description is incomplete; ensure all items are checked before requesting a review.

@AliQassab AliQassab removed the needreview PR is pending AI review label Mar 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab AliQassab closed this Mar 8, 2026
@AliQassab AliQassab reopened this Mar 8, 2026
@AliQassab AliQassab added the needreview PR is pending AI review label Mar 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab
Copy link
Copy Markdown
Owner Author

Summary

This PR is intended to implement a Least Recently Used (LRU) cache using the OrderedDict from Python's collections module. However, no files have been changed in this PR, so there is no code to review.

Positive Feedback

  • The intention to use OrderedDict for implementing an LRU cache is a good choice as it maintains the order of keys, which is essential for LRU functionality.

Issues Found

  • No files have been changed in this PR, which means there is no implementation to review. Please ensure that the code changes are committed and pushed to the branch associated with this PR.
  • The PR title does not follow the specified format: "Region | Cohort | FirstName LastName | Sprint | Assignment Title".
  • The self-checklist in the PR description has not been completed.

@AliQassab AliQassab removed the needreview PR is pending AI review label Mar 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab AliQassab closed this Mar 8, 2026
@AliQassab AliQassab reopened this Mar 8, 2026
@AliQassab AliQassab added the needreview PR is pending AI review label Mar 8, 2026
@AliQassab
Copy link
Copy Markdown
Owner Author

Summary

This PR aims to implement a Least Recently Used (LRU) cache using Python's OrderedDict from the collections module. However, no files have been changed in this PR, which suggests that the implementation might be missing or not committed.

Positive Feedback

  • The PR description follows a structured template, which is good for maintaining consistency and clarity.

Issues Found

  • No Changed Files: The PR currently shows no changed files, which means the implementation of the LRU cache is not present. This needs to be addressed before a review of the code can be conducted.
  • Incomplete Self Checklist: The self checklist in the PR description has not been completed. It's important to ensure that the checklist is fully addressed to maintain quality standards.
  • PR Title Format: The PR title does not follow the required format of "Region | Cohort | FirstName LastName | Sprint | Assignment Title" as specified in the template.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab AliQassab added reviewed Code reviewed — improvements needed and removed needreview PR is pending AI review labels Mar 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

2 similar comments
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@AliQassab AliQassab closed this Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed Code reviewed — improvements needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant