Skip to content

build(root): add corepack support and fix eslint config resolution #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cswenor
Copy link

@cswenor cswenor commented May 3, 2025

This PR adds the "packageManager" field to the root package.json to support Corepack-based development using pnpm. It also updates the ESLint config to use the unified typescript-eslint package, fixing module resolution issues when using flat config.

All checks pass:

  • ✅ pnpm lint
  • ✅ pnpm format
  • ✅ pnpm typecheck

No breaking changes introduced.

@cswenor
Copy link
Author

cswenor commented May 3, 2025

PS I'm also running into issues just running the examples locally, but I'm considering it user error until I dig in deeper.

@drichar
Copy link
Collaborator

drichar commented Jul 9, 2025

Hi @cswenor I'm sorry I missed this PR! I just updated dependencies in #6 and also added the packageManager field to the root package.json.

This introduced conflicts in your PR. Sorry about that as well. If you can resolve these I'll merge your update unifying the typescript-eslint packages. Or if it's easier, close this one and create a new PR instead. I'll keep a close eye out for it. Thanks!!

@drichar
Copy link
Collaborator

drichar commented Jul 9, 2025

Also, let me know what issues you were/are having running the examples and I'll take a look.

@cswenor
Copy link
Author

cswenor commented Jul 9, 2025

Your PR fixed my issues, it made me laugh when I saw you do a PR after I submitted my PR but I figured you didn't see it or you were trying to avoid politics with not having my name on the repo haha. Either way I really appreciate all the work you do.

You can just delete this PR.

@drichar
Copy link
Collaborator

drichar commented Jul 10, 2025

Your PR fixed my issues, it made me laugh when I saw you do a PR after I submitted my PR but I figured you didn't see it or you were trying to avoid politics with not having my name on the repo haha. Either way I really appreciate all the work you do.

You can just delete this PR.

Nooo it was the former, definitely not the latter! All contributions are appreciated, and all contributors are welcome. It was my mistake for missing your PR. Please feel free to open another one any time.

@drichar drichar closed this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants