Cm/symbolictypes #71
Merged
Cm/symbolictypes #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpfairbanks
requested changes
Aug 30, 2024
| end | ||
| end | ||
|
|
||
| function SymbolicContext(d::decapodes.DecaExpr, __module__=@__MODULE__) |
There was a problem hiding this comment.
When you call this with 1 arguement, does this @__MODULE__ resolves to SymbolicUtilsInterop or to Main?
jpfairbanks
requested changes
Aug 30, 2024
|
|
||
| ``` | ||
| @register foo(S1, S2, ...)::ThDEC begin | ||
| @operator foo(S1, S2, ...)::Theory begin |
There was a problem hiding this comment.
ahh, I see that this return type is like a categories as contexts approach. We are using the abstract type that all of our symbolic quantities inhabit as the "category as context" to anchor the algebraic theory on. I like this as a hybrid between the Catlab/Gatlab approach to explicit theories as the starting point and the SymbolicUtils "a number is a thing you can do math on" approach that minimizes the role of the algebraic theory.
jpfairbanks
requested changes
Sep 9, 2024
Bugfix to cm/symbolictypes
…aticEquations.jl into cm/symbolictypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.