Type fix #31
Merged
Type fix #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/osp/bsp/scheduler/LocalSearch/KernighanLin_v2/kl_improver.hpp
Outdated
Show resolved
Hide resolved
include/osp/dag_divider/isomorphism_divider/IsomorphicSubgraphScheduler.hpp
Outdated
Show resolved
Hide resolved
include/osp/dag_divider/isomorphism_divider/IsomorphicSubgraphScheduler.hpp
Outdated
Show resolved
Hide resolved
raphael-s-steiner
previously approved these changes
Nov 11, 2025
Collaborator
raphael-s-steiner
left a comment
raphael-s-steiner
left a comment
There was a problem hiding this comment.
Left a couple of comments. Looks good
raphael-s-steiner
previously approved these changes
Nov 11, 2025
Collaborator
raphael-s-steiner
left a comment
raphael-s-steiner
left a comment
There was a problem hiding this comment.
All looks good
papp-pal-andras
previously approved these changes
Nov 11, 2025
Collaborator
papp-pal-andras
left a comment
papp-pal-andras
left a comment
There was a problem hiding this comment.
Cool! This must have been fun to do...
(I'll try to do some renaming later when I get the time, e.g. remaining_2 in pebbling, but don't wait for that with the merge)
papp-pal-andras
previously approved these changes
Nov 11, 2025
raphael-s-steiner
approved these changes
Nov 12, 2025
Collaborator
raphael-s-steiner
left a comment
raphael-s-steiner
left a comment
There was a problem hiding this comment.
Looks all good to me now!
papp-pal-andras
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.