478 vector rework and vector views #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2022 16:50
Map i in 1D to (i,i) in 2D Update the method to get vector length
ghost
requested a review
from
added 13 commits
August 10, 2022 14:06
…x static properties
(only the ones that take one parameter)
to allow for constructing based on Id and Zero IMFs
hidanielesgit
approved these changes
Aug 15, 2022
added 5 commits
August 15, 2022 13:38
Currently it is not used.
hidanielesgit
approved these changes
Aug 15, 2022
include/alp/storage.hpp
Outdated
| typedef AMF< imf::Id, imf::Id, PolyType > amf_type; | ||
|
|
||
| /** | ||
| * Factory method used for matrices. |
There was a problem hiding this comment.
matrices -> instances of mapping functions and associated storage ?
include/alp/storage.hpp
Outdated
| * fact that fusion of strided IMFs into the polynomial always | ||
| * succeeds and results in Id IMFs. As a result, the constructed | ||
| * AMF is of the type \a amf_type. | ||
| * Factory method used for AMF associated with a matrix representing |
There was a problem hiding this comment.
a matrix representing a vector -> a vector container?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.