-
Notifications
You must be signed in to change notification settings - Fork 6
171 grbcxx when performing shared linking still selects static libraries #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
171 grbcxx when performing shared linking still selects static libraries #287
Conversation
a963723 to
4828c0b
Compare
2c96fad to
c07d450
Compare
aee7226 to
409b0a8
Compare
anyzelman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor comment, and a question: is there someone else besides you who could review the cmake changes? I'm not an expert at it myself and may miss some finer points of changes there
Kindly inviting @byjtew to chime in and inspect the CMake changes |
|
Manual tests detect an issue with the Following these steps (without the --link-alp-static option) does work for the |
|
Also the new |
19c1225 to
273ddd5
Compare
|
Sorry, now a sort of reversed error as last week: I suppose the libalp_utils should also be linked statically. The default / dynamic linkage case is now behaving as expected: Only a minor thingy, in the |
|
Also (sorry for piling up minor issues): if grbcxx has a |
36364c5 to
cb61f5f
Compare
Yes, it was implemented alongside the |
607e6ef to
790c3ac
Compare
790c3ac to
2d0a4b6
Compare
This issue is solved by:
--alp-link-dynamicto link dynamic ALP libraries