OPSEXP-2950 Prepare to update to Elasticsearch 8 by switching to the bitnami/elasticsearch chart #1267
+385
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxgomz
requested changes
Dec 19, 2024
helm/alfresco-content-services/templates/config-infrastructure.yaml
Outdated
Show resolved
Hide resolved
helm/alfresco-content-services/templates/config-infrastructure.yaml
Outdated
Show resolved
Hide resolved
alxgomz
requested changes
Dec 20, 2024
pmacius
changed the title
pmacius
requested review from
gionn and
alxgomz
and removed request for
alxgomz
gionn
reviewed
Jan 8, 2025
alxgomz
reviewed
Jan 8, 2025
Co-authored-by: Alex Chapellon <alexandre.Chapellon@hyland.com>
alxgomz
reviewed
Jan 9, 2025
There was a problem hiding this comment.
We should make it clear this is in case one uses the embedded elasticsearch which is not recommended for prod
alxgomz
approved these changes
Jan 9, 2025
gionn
reviewed
Jan 9, 2025
| --from-literal=AUDIT_ELASTICSEARCH_USERNAME=$ELASTIC_USERNAME \ | ||
| --from-literal=AUDIT_ELASTICSEARCH_PASSWORD=$ELASTIC_PASSWORD \ | ||
| --from-literal=SEARCH_USERNAME=$ELASTIC_USERNAME \ | ||
| --from-literal=SEARCH_PASSWORD=$ELASTIC_PASSWORD |
There was a problem hiding this comment.
see --from-env-file which should prevent user leaking credentials in its history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: OPSEXP-2950