Skip to content

Switched editor from Ace to Monaco #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

skrashevich
Copy link
Contributor

Replaced Ace Editor with Monaco Editor in editor.html for an enhanced editing experience.

Replaced Ace Editor with Monaco Editor in editor.html for an enhanced
editing experience.
@AlexxIT
Copy link
Owner

AlexxIT commented May 18, 2024

4 spaces for tabs in YAML should be fixed.

@AlexxIT AlexxIT self-assigned this May 18, 2024
@skrashevich
Copy link
Contributor Author

4 spaces for tabs in YAML should be fixed.

make sense. fixed

@skrashevich
Copy link
Contributor Author

skrashevich commented May 21, 2024

image Implemented configuration validation with guidance prompts.

The configuration scheme needs polishing before merging.

@AlexxIT
Copy link
Owner

AlexxIT commented May 24, 2024

I don't like monaco-yaml-prebuilt idea.

@skrashevich
Copy link
Contributor Author

I don't like monaco-yaml-prebuilt idea.

Me too. But this is the only option without local build and storage of the editor bundle. (however, it can be stored on the go2rtc GitHub pages)

@AlexxIT
Copy link
Owner

AlexxIT commented May 24, 2024

Why do we need bundle? Is it only for tabs? Or also for yaml support?

@skrashevich
Copy link
Contributor Author

skrashevich commented May 24, 2024

Why do we need bundle? Is it only for tabs? Or also for yaml support?

It's needed for completion, hints, and validation support for YAML.
Without it the original package can be used

Unfortunately, extended YAML support is only available in external package, which is designed for use in the node-js environment. I couldn’t make it work without building it into a single package 😔

In any case, the build used has open source which allows it to be easily rebuild with new versions, and the current versions used will always be available on npmjs and services like unpkg.

@AlexxIT
Copy link
Owner

AlexxIT commented May 27, 2024

I have tested this https://monaco-yaml.js.org/ with # yaml-language-server: $schema=https:// start line.
It works awesome. We can try to use default monaco bundle and host this JS worker and schema.json on github pages.

@skrashevich
Copy link
Contributor Author

I have tested this https://monaco-yaml.js.org/ with # yaml-language-server: $schema=https:// start line. It works awesome. We can try to use default monaco bundle and host this JS worker and schema.json on github pages.

Awesome. I couldn't get it to work in such configuration. I would like to see the code that worked

@AlexxIT AlexxIT assigned AlexxIT and unassigned AlexxIT May 28, 2024
@AlexxIT AlexxIT removed their assignment Feb 24, 2025
@AlexxIT AlexxIT added the doubt label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants