-
Notifications
You must be signed in to change notification settings - Fork 646
Switched editor from Ace to Monaco #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Replaced Ace Editor with Monaco Editor in editor.html for an enhanced editing experience.
4 spaces for tabs in YAML should be fixed. |
make sense. fixed |
I don't like |
Me too. But this is the only option without local build and storage of the editor bundle. (however, it can be stored on the go2rtc GitHub pages) |
Why do we need bundle? Is it only for tabs? Or also for yaml support? |
It's needed for completion, hints, and validation support for YAML. Unfortunately, extended YAML support is only available in external package, which is designed for use in the node-js environment. I couldn’t make it work without building it into a single package 😔 In any case, the build used has open source which allows it to be easily rebuild with new versions, and the current versions used will always be available on npmjs and services like unpkg. |
I have tested this https://monaco-yaml.js.org/ with |
Awesome. I couldn't get it to work in such configuration. I would like to see the code that worked |
Replaced Ace Editor with Monaco Editor in editor.html for an enhanced editing experience.