Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Deprecate molecular-subtyping-SHH-tp53 #495

Merged

Conversation

jaclyn-taroni
Copy link
Member

Purpose/implementation Section

#247 was closed 5 days ago because we don't have all the necessary information to further divide SHH MB samples into SHH, TP53-mutated and SHH, TP53-wildtype. Here I'm adding documentation to the molecular-subtyping-SHH-tp53 README and to the analyses README that notes this module is deprecated and that the results should not be used for subtyping.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.

Copy link
Contributor

@cbethell cbethell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should this analysis also be commented out of circleci?

@jaclyn-taroni
Copy link
Member Author

Good idea @cbethell, I'll make that change!

@jaclyn-taroni jaclyn-taroni merged commit 76612dc into AlexsLemonade:master Feb 3, 2020
@jaclyn-taroni jaclyn-taroni deleted the mb-shh-no-germline branch February 3, 2020 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants