Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

V11 Release #293

Merged
merged 18 commits into from
Dec 2, 2019
Merged

V11 Release #293

merged 18 commits into from
Dec 2, 2019

Conversation

yuankunzhu
Copy link
Collaborator

@yuankunzhu yuankunzhu commented Nov 26, 2019

Purpose/implementation

data release updates for v10

Issue/Caveats

Directions for reviewers

changed on release notes and download script.

  • release file added:

    • pbta-fusion-putative-oncogenic.tsv
    • pbta-snv-consensus-20191125.zip
    • pbta-gene-expression-rsem-fpkm-collapsed.polya.rds
    • pbta-gene-expression-rsem-fpkm-collapsed.stranded.rds
    • pbta-snv-consensus-mutation.maf.tsv.gz
    • pbta-snv-consensus-mutation-tmb.tsv
  • release file removed:

    • pbta-gene-expression-rsem-fpkm-collapsed_table.polya.rds
    • pbta-gene-expression-rsem-fpkm-collapsed_table.stranded.rds
    • pbta-snv-consensus_11122019.zip

@jaclyn-taroni
Copy link
Member

@yuankunzhu it looks like this includes a zip file of the consensus information:

pbta-snv-consensus-20191125.zip: OK
Archive:  data/pbta-snv-consensus-20191125.zip
   creating: data/snv-consensus-20191125/
  inflating: data/snv-consensus-20191125/consensus_mutation_tmb.tsv  
  inflating: data/snv-consensus-20191125/README.md  
  inflating: data/snv-consensus-20191125/consensus_mutation.maf.tsv 

Can we rename these files and include them in the top directory alongside the other files per this comment #287 (comment)? Copying the relevant part below for your reference:

Regarding the new consensus mutation files, I think since we will probably put the pbta-fusion-putative-oncogenic.tsv directly in the release folder, we should make some changes to how the consensus mutation files are distributed.

The file structure of snv-consensus-20191125.zip is as follows:

 .
├── README.md
├── consensus_mutation.maf.tsv
└── consensus_mutation_tmb.tsv

Could we rename the contents to:
consensus_mutation.maf.tsv -> pbta-snv-consensus-mutation.maf.tsv (+ possibly compress this file)
consensus_mutation_tmb.tsv -> pbta-snv-consensus-mutation-tmb.tsv

And then include these in the "top directory" of the release folder?

@yuankunzhu
Copy link
Collaborator Author

yuankunzhu commented Nov 26, 2019

sure thing @jaclyn-taroni.
just made the change, please review.

@jaclyn-taroni
Copy link
Member

My apologies, my comment about compressing the MAF file was ambiguous. I would expect that file to be gzipped to be consistent with the other files and then for the unzip steps at lines 51-52 to come out of download-data.sh.

@yuankunzhu
Copy link
Collaborator Author

yuankunzhu commented Nov 26, 2019

ah no worries. i was thinking about that too.
so just to be clear, we'd like to have pbta-snv-consensus-mutation.maf.tsv.gz up there instead of pbta-snv-consensus-mutation.maf.tsv.zip?

@jaclyn-taroni
Copy link
Member

Yes that’s what I was thinking, thanks.

@jaclyn-taroni
Copy link
Member

With 112019e I was mostly checking if edits by maintainers was allowed because I would like the folks that generated the consensus mutation files (@cansavvy, @jashapiro) to include documentation in the README as part of this pull request per #287 (comment) and #287 (comment).

@jharenza jharenza mentioned this pull request Dec 2, 2019
2 tasks
@jaclyn-taroni
Copy link
Member

I got the 👍 over on #299, so I will merge those changes into this branch.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jaclyn-taroni jaclyn-taroni merged commit d23b5f0 into AlexsLemonade:master Dec 2, 2019
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants