-
Notifications
You must be signed in to change notification settings - Fork 83
Conversation
@yuankunzhu it looks like this includes a zip file of the consensus information:
Can we rename these files and include them in the top directory alongside the other files per this comment #287 (comment)? Copying the relevant part below for your reference:
|
sure thing @jaclyn-taroni. |
My apologies, my comment about compressing the MAF file was ambiguous. I would expect that file to be gzipped to be consistent with the other files and then for the unzip steps at lines 51-52 to come out of |
ah no worries. i was thinking about that too. |
Yes that’s what I was thinking, thanks. |
With 112019e I was mostly checking if edits by maintainers was allowed because I would like the folks that generated the consensus mutation files (@cansavvy, @jashapiro) to include documentation in the README as part of this pull request per #287 (comment) and #287 (comment). |
These were not committed in the first place, trying to make local development easier
I got the 👍 over on #299, so I will merge those changes into this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Purpose/implementation
data release updates for v10
Issue/Caveats
Directions for reviewers
changed on release notes and download script.
release file added:
release file removed: