Skip to content

Commit

Permalink
chore(dependencies): add packaging dependency
Browse files Browse the repository at this point in the history
With packaging we have better support for parsing package information.

packaging is slated to become independent of setuptools and
pkg_resources.

Additionally, it is better supported by mypy.

Add dependency also in mypy for pre-commit.
  • Loading branch information
Alexei95 committed Mar 12, 2022
1 parent 52192e3 commit 9958cd5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ repos:
# pytorch-lightning>=1.4.5,
# sqlalchemy>=1.4.22,
# torch>=1.9,
"packaging==21.0",
"sqlalchemy[mypy]==1.4.22",
"types-setuptools==57.4.2",
"types-pkg-resources==0.1.3",
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,12 @@
dependencies = [
# for pkg_resources, to parse version info from optional requirements
"setuptools >= 58.0",
"packaging >= 20.0",
]

[[project.author]]
name = "Alessio Colucci"
email = "alessio.colucci@pm.me"
email = "pm@alexei95.aleeas.com"


[project.license]
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
# dependencies
install_requires=[
"setuptools >= 58.0",
"packaging >= 20.0",
],
extras_require={
"full": [
Expand Down

0 comments on commit 9958cd5

Please sign in to comment.