Remove mypy from pre-commit.

Fix mypy config in pyproject.toml.

.pre-commit-config.yaml

@@ -31,22 +31,24 @@ repos:
     rev: 3.7.9
     hooks:
     -   id: flake8
--   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.910-1  # Use the sha / tag you want to point at
-    hooks:
-    -   id: mypy
-        # the additional dependencies are installed if required in the
-        # execution
-        # additional_dependencies: [
-        #     cupy>=9.4.0,
-        #     numpy,
-        #     pytorch-lightning>=1.4.5,
-        #     sqlalchemy>=1.4.22,
-        #     torch>=1.9,
-        # ]
-        args: [
-            # --no-strict-optional,
-            # mypy is used from a venv, so it will not have all the
-            # dependencies available
-            --ignore-missing-imports
-        ]
+# mypy and pre-commit hooks are not nice together if the project
+# has dependencies which are difficult to install
+# for now we simply run it locally and later also in a CI
+# -   repo: https://github.com/pre-commit/mirrors-mypy
+#     rev: v0.910-1  # Use the sha / tag you want to point at
+#     hooks:
+#     -   id: mypy
+#         # the additional dependencies are installed if required in the
+#         # execution
+#         # additional_dependencies: [
+#         #     cupy>=9.4.0,
+#         #     numpy,
+#         #     pytorch-lightning>=1.4.5,
+#         #     sqlalchemy>=1.4.22,
+#         #     torch>=1.9,
+#         # ]
+#         args: [
+#             # mypy is used from a venv, so it will not have all the
+#             # dependencies available
+#             --ignore-missing-imports
+#         ]

pyproject.toml

@@ -29,7 +29,23 @@ extend-exclude = '''
 '''
 
 [tool.mypy]
+# Typing tests is low priority, but enabling type checking on the
+# untyped test functions (using `--check-untyped-defs`) is still
+# high-value because it helps test the typing.
+# taken from https://github.com/PyTorchLightning/pytorch-lightning/blob/1c8ad3a94bce2d0b5e62b5e5a4395bb6fb25642d/setup.cfg#L95
 python_version = "3.9"
+disallow_untyped_defs = true
+# ignore_missing_imports = true
+show_error_codes = true
+warn_redundant_casts = true
+warn_unused_configs = true
+warn_unused_ignores = true
+
+# we skip the errors because of the import problems
+# however this needs to be added only for the pre-commit hook
+# [[tool.mypy.overrides]]
+# module = "enpheeph.*"
+# ignore_errors = true
 
 # use the following section as example for custom mypy module configurations
 # [[tool.mypy.overrides]]